jedit-devel Mailing List for jEdit

Plugin Bugs item #3608399, was opened at 2013-03-18 10:11
Message generated for change (Comment added) made by ezust
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=3608399&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Project Viewer
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Alan Ezust (ezust)
Assigned to: Dale Anson (daleanson)
Summary: Auto-Import Files to Project should consider ignore dirs

Initial Comment:
If I have the option "auto-add files to project", it should ignore files that are in the "directories to ignore" specification of the projectviewer reimport options.

Currently, it auto-adds files like .git/COMMIT_EDITMSG which it should not ever add to the project.


----------------------------------------------------------------------

>Comment By: Alan Ezust (ezust)
Date: 2013-03-31 09:44

Message:
looked at the code involved. ProjectViewer line 1251. Now that is what I
call ugly-ass code!
And probably must be cleaned up or refactored somehow in order to implement
this.


----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2013-03-18 10:32

Message:
I tried adding !COMMIT_EDITMSG to the "files to import", and it is also not
considered during auto-import. 


----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2013-03-18 10:15

Message:
Let me clarify. The option is "importing new files" and the radio button
chosen is "auto import"


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=3608399&group_id=588

Patches item #3607873, was opened at 2013-03-13 03:36
Message generated for change (Comment added) made by shlomy
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3607873&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: texteditor
Group: None
>Status: Pending
Resolution: None
Priority: 5
Private: No
Submitted By: Marc Häfner (marchaefner)
Assigned to: Shlomy Reinstein (shlomy)
Summary: Fix cursor misplacement with auto-indent.

Initial Comment:
This fixes a subtle bug introduced in rev. 14899, where
`insertEnterAndIndent` sometimes places the cursor at the wrong column.

Example
-------
(python, underscores for spaces, vbar for cursor)

Given the following situation, with auto-indent and an indentation level
of 2 spaces. (Note that the amount of spaces after the cursor matches
the indentation level for the next line):

    if_False:|__pass

Executing `insertEnterAndIndent` (default action for ENTER key) results
in:

    if_False:
    |__pass

Expected outcome would be (and is for different amount of spaces):

    if_False:
    __|pass

Cause
-----
This behaviour is caused by an early return in `JEditBuffer.indentLine`
if `idealIndent == currentIndent`. While this is necessary for
`insertTabAndIndent`, it prevents re-indentation which would produce a
correct cursor position.

Fix
---
`indentLine` already has a parameter `canDecreaseIndent` which is only
used by `insertTabAndIndent`. This fix simply reuses that flag and
prevent re-indentation to the same level only for the Tab key.

Side Effects
------------
The fix reverts to the behaviour before rev. 14899 (2009-04-09), except
for the Tab key. I.e. `indentLine` no longer always returns `false` if a
line is already correctly indented. Within the jEdit project only
`insertTabAndIndent` uses the return value.

----------------------------------------------------------------------

>Comment By: Shlomy Reinstein (shlomy)
Date: 2013-03-31 03:03

Message:
This patch has a side-effect of not preserving the leading whitespace in
case the ideal indentation level is the same as the current (existing)
indentation level.
I recall that there was an explicit request (don't remember why) to
preserve the existing whitespace if the level of indentation is okay.
Personally, I'd prefer jEdit to replace the leading whitespace with the
default (e.g. if my leading whitespace is mixed spaces and tabs, I'd prefer
auto-indent to replace the spaces with tabs) - which is what this patch
does. I don't remember why we didn't do it this way, but there was a good
reason for the current behavior (without the patch).
It would be okay to move the cursor to the right place, but without having
any side effects like the above.

----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2013-03-16 16:59

Message:
I am testing it now and trying to observe some change in behavior and am
unable to see any yet. 
Shlomy is on vacation but I thought he should take a look at it too when he
gets back since 14899 is his revision.
it's just a 2-liner patch and looks fine to me so far though.



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3607873&group_id=588

Patches item #3609561, was opened at 2013-03-30 11:15
Message generated for change (Comment added) made by kerik-sf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3609561&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Eric Le Lay (kerik-sf)
Assigned to: Nobody/Anonymous (nobody)
Summary: fix for #2940864 - Exception when clicking Find orphan

Initial Comment:
fix for https://sourceforge.net/tracker/index.php?func=detail&aid=2940864&group_id=588&atid=100588

attached is a fix for the exceptions when clicking Find orphan when some plugins are disabled.

Main fix is to check PluginJAR.generateCache() if reading actions.xml, services.xml, dockables.xml has a chance to succeed before trying to do it.

It contains robustness checks (is InputStream null before parsing from it) in ServicesManager, JEditActionSet, DockableWindowFactory. They are not strictly necessary, since they don't get called anymore.

----------------------------------------------------------------------

>Comment By: Eric Le Lay (kerik-sf)
Date: 2013-03-30 14:09

Message:
also fix a NullPointerException when a not loaded plugin's cache can not be
loaded.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3609561&group_id=588

Bugs item #2940864, was opened at 2010-01-27 01:59
Message generated for change (Settings changed) made by kerik-sf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=2940864&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: plugin manager
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Matthieu Casanova (kpouer)
>Assigned to: Eric Le Lay (kerik-sf)
Summary: Exception when clicking Find orphan when disabled plugins

Initial Comment:
It seems that when trying to load actions.xml of some jars, if it doesn't exists there is an exception.
It happens a lot when doing a "find orphan" action in the Plugin Manager.
I don't think we should print a stacktrace here since it is not mandatory to have actions in a plugin

java.io.IOException: Resource not found: WhiteSpace.jar!actions.xml
	at org.gjt.sp.jedit.proto.jeditresource.PluginResURLConnection.connect(PluginResURLConnection.java:88)
	at org.gjt.sp.jedit.proto.jeditresource.Handler.openConnection(Handler.java:46)
	at java.net.URL.openConnection(URL.java:945)
	at java.net.URL.openStream(URL.java:1010)
	at org.gjt.sp.jedit.JEditActionSet.load(JEditActionSet.java:385)
	at org.gjt.sp.jedit.PluginJAR.generateCache(PluginJAR.java:1328)
	at org.gjt.sp.jedit.pluginmgr.ManagePanel$FindOrphan.actionPerformed(ManagePanel.java:1020)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
	at org.jvnet.substance.utils.RolloverButtonListener.mouseReleased(RolloverButtonListener.java:111)
	at java.awt.Component.processMouseEvent(Component.java:6263)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
	at java.awt.Component.processEvent(Component.java:6028)
	at java.awt.Container.processEvent(Container.java:2041)
	at java.awt.Component.dispatchEventImpl(Component.java:4630)
	at java.awt.Container.dispatchEventImpl(Container.java:2099)
	at java.awt.Component.dispatchEvent(Component.java:4460)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4574)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
	at java.awt.Container.dispatchEventImpl(Container.java:2085)
	at java.awt.Window.dispatchEventImpl(Window.java:2475)
	at java.awt.Component.dispatchEvent(Component.java:4460)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)


----------------------------------------------------------------------

Comment By: Eric Le Lay (kerik-sf)
Date: 2013-03-30 11:15

Message:
see fix in
https://sourceforge.net/tracker/?func=detail&aid=3609561&group_id=588&atid=300588

----------------------------------------------------------------------

Comment By: Eric Le Lay (kerik-sf)
Date: 2013-03-30 11:06

Message:
This exception doesn't appear as such anymore, because
PluginResURLConnection.openStream() now silently returns null.

New exception:
(log)
ActionSet: Loading actions from
jeditresource:/UpdaterPlugin.jar!/actions.xml
(exception)
ActionSet: java.io.IOException: Stream closed
ActionSet:  at
java.io.BufferedInputStream.getInIfOpen(BufferedInputStream.java:151)
ActionSet:  at
java.io.BufferedInputStream.fill(BufferedInputStream.java:235)
ActionSet:  at
java.io.BufferedInputStream.read(BufferedInputStream.java:254)
ActionSet:  at
com.sun.org.apache.xerces.internal.impl.XMLEntityManager$RewindableInputStr
ActionSet:  at
com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEntity
ActionSet:  at
com.sun.org.apache.xerces.internal.impl.XMLVersionDetector.determineDocVers
ActionSet:  at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Co
ActionSet:  at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Co
ActionSet:  at
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:1
ActionSet:  at
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(Abstract
ActionSet:  at
org.gjt.sp.util.XMLUtilities.parseXML(XMLUtilities.java:140)
ActionSet:  at
org.gjt.sp.jedit.JEditActionSet.load(JEditActionSet.java:394)
ActionSet:  at
org.gjt.sp.jedit.PluginJAR.generateCache(PluginJAR.java:1457)
ActionSet:  at
org.gjt.sp.jedit.pluginmgr.ManagePanel$FindOrphan.actionPerformed(ManagePan
ActionSet:  at
javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2018)
ActionSet:  at
javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2341
ActionSet:  at
javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:
ActionSet:  at
javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
ActionSet:  at
javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListene
ActionSet:  at java.awt.Component.processMouseEvent(Component.java:6505)
ActionSet:  at
javax.swing.JComponent.processMouseEvent(JComponent.java:3312)
ActionSet:  at java.awt.Component.processEvent(Component.java:6270)
ActionSet:  at java.awt.Container.processEvent(Container.java:2229)
ActionSet:  at java.awt.Component.dispatchEventImpl(Component.java:4861)
ActionSet:  at java.awt.Container.dispatchEventImpl(Container.java:2287)
ActionSet:  at java.awt.Component.dispatchEvent(Component.java:4687)
ActionSet:  at
java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4832)
ActionSet:  at
java.awt.LightweightDispatcher.processMouseEvent(Container.java:4492)
ActionSet:  at
java.awt.LightweightDispatcher.dispatchEvent(Container.java:4422)
ActionSet:  at java.awt.Container.dispatchEventImpl(Container.java:2273)
ActionSet:  at java.awt.Window.dispatchEventImpl(Window.java:2719)
ActionSet:  at java.awt.Component.dispatchEvent(Component.java:4687)
ActionSet:  at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:729)
ActionSet:  at java.awt.EventQueue.access$200(EventQueue.java:103)
ActionSet:  at java.awt.EventQueue$3.run(EventQueue.java:688)
ActionSet:  at java.awt.EventQueue$3.run(EventQueue.java:686)
ActionSet:  at java.security.AccessController.doPrivileged(Native Method)
ActionSet:  at
java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.j
ActionSet:  at
java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.j
ActionSet:  at java.awt.EventQueue$4.run(EventQueue.java:702)
ActionSet:  at java.awt.EventQueue$4.run(EventQueue.java:700)
ActionSet:  at java.security.AccessController.doPrivileged(Native Method)
ActionSet:  at
java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.j
ActionSet:  at java.awt.EventQueue.dispatchEvent(EventQueue.java:699)
ActionSet:  at
java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.jav
ActionSet:  at
java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:1
ActionSet:  at
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.jav
ActionSet:  at
java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
ActionSet:  at
java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
ActionSet:  at
java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

I can reproduce it when clicking find orphan with inactive plugins. I get 3
stack traces for every plugin (when loading actions.xml, dockables.xml,
services.xml)



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=2940864&group_id=588

Bugs item #2940864, was opened at 2010-01-27 01:59
Message generated for change (Comment added) made by kerik-sf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=2940864&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: plugin manager
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Matthieu Casanova (kpouer)
Assigned to: Nobody/Anonymous (nobody)
>Summary: Exception when clicking Find orphan when disabled plugins

Initial Comment:
It seems that when trying to load actions.xml of some jars, if it doesn't exists there is an exception.
It happens a lot when doing a "find orphan" action in the Plugin Manager.
I don't think we should print a stacktrace here since it is not mandatory to have actions in a plugin

java.io.IOException: Resource not found: WhiteSpace.jar!actions.xml
	at org.gjt.sp.jedit.proto.jeditresource.PluginResURLConnection.connect(PluginResURLConnection.java:88)
	at org.gjt.sp.jedit.proto.jeditresource.Handler.openConnection(Handler.java:46)
	at java.net.URL.openConnection(URL.java:945)
	at java.net.URL.openStream(URL.java:1010)
	at org.gjt.sp.jedit.JEditActionSet.load(JEditActionSet.java:385)
	at org.gjt.sp.jedit.PluginJAR.generateCache(PluginJAR.java:1328)
	at org.gjt.sp.jedit.pluginmgr.ManagePanel$FindOrphan.actionPerformed(ManagePanel.java:1020)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
	at org.jvnet.substance.utils.RolloverButtonListener.mouseReleased(RolloverButtonListener.java:111)
	at java.awt.Component.processMouseEvent(Component.java:6263)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
	at java.awt.Component.processEvent(Component.java:6028)
	at java.awt.Container.processEvent(Container.java:2041)
	at java.awt.Component.dispatchEventImpl(Component.java:4630)
	at java.awt.Container.dispatchEventImpl(Container.java:2099)
	at java.awt.Component.dispatchEvent(Component.java:4460)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4574)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
	at java.awt.Container.dispatchEventImpl(Container.java:2085)
	at java.awt.Window.dispatchEventImpl(Window.java:2475)
	at java.awt.Component.dispatchEvent(Component.java:4460)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)


----------------------------------------------------------------------

>Comment By: Eric Le Lay (kerik-sf)
Date: 2013-03-30 11:15

Message:
see fix in
https://sourceforge.net/tracker/?func=detail&aid=3609561&group_id=588&atid=300588

----------------------------------------------------------------------

Comment By: Eric Le Lay (kerik-sf)
Date: 2013-03-30 11:06

Message:
This exception doesn't appear as such anymore, because
PluginResURLConnection.openStream() now silently returns null.

New exception:
(log)
ActionSet: Loading actions from
jeditresource:/UpdaterPlugin.jar!/actions.xml
(exception)
ActionSet: java.io.IOException: Stream closed
ActionSet:  at
java.io.BufferedInputStream.getInIfOpen(BufferedInputStream.java:151)
ActionSet:  at
java.io.BufferedInputStream.fill(BufferedInputStream.java:235)
ActionSet:  at
java.io.BufferedInputStream.read(BufferedInputStream.java:254)
ActionSet:  at
com.sun.org.apache.xerces.internal.impl.XMLEntityManager$RewindableInputStr
ActionSet:  at
com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEntity
ActionSet:  at
com.sun.org.apache.xerces.internal.impl.XMLVersionDetector.determineDocVers
ActionSet:  at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Co
ActionSet:  at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Co
ActionSet:  at
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:1
ActionSet:  at
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(Abstract
ActionSet:  at
org.gjt.sp.util.XMLUtilities.parseXML(XMLUtilities.java:140)
ActionSet:  at
org.gjt.sp.jedit.JEditActionSet.load(JEditActionSet.java:394)
ActionSet:  at
org.gjt.sp.jedit.PluginJAR.generateCache(PluginJAR.java:1457)
ActionSet:  at
org.gjt.sp.jedit.pluginmgr.ManagePanel$FindOrphan.actionPerformed(ManagePan
ActionSet:  at
javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2018)
ActionSet:  at
javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2341
ActionSet:  at
javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:
ActionSet:  at
javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
ActionSet:  at
javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListene
ActionSet:  at java.awt.Component.processMouseEvent(Component.java:6505)
ActionSet:  at
javax.swing.JComponent.processMouseEvent(JComponent.java:3312)
ActionSet:  at java.awt.Component.processEvent(Component.java:6270)
ActionSet:  at java.awt.Container.processEvent(Container.java:2229)
ActionSet:  at java.awt.Component.dispatchEventImpl(Component.java:4861)
ActionSet:  at java.awt.Container.dispatchEventImpl(Container.java:2287)
ActionSet:  at java.awt.Component.dispatchEvent(Component.java:4687)
ActionSet:  at
java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4832)
ActionSet:  at
java.awt.LightweightDispatcher.processMouseEvent(Container.java:4492)
ActionSet:  at
java.awt.LightweightDispatcher.dispatchEvent(Container.java:4422)
ActionSet:  at java.awt.Container.dispatchEventImpl(Container.java:2273)
ActionSet:  at java.awt.Window.dispatchEventImpl(Window.java:2719)
ActionSet:  at java.awt.Component.dispatchEvent(Component.java:4687)
ActionSet:  at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:729)
ActionSet:  at java.awt.EventQueue.access$200(EventQueue.java:103)
ActionSet:  at java.awt.EventQueue$3.run(EventQueue.java:688)
ActionSet:  at java.awt.EventQueue$3.run(EventQueue.java:686)
ActionSet:  at java.security.AccessController.doPrivileged(Native Method)
ActionSet:  at
java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.j
ActionSet:  at
java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.j
ActionSet:  at java.awt.EventQueue$4.run(EventQueue.java:702)
ActionSet:  at java.awt.EventQueue$4.run(EventQueue.java:700)
ActionSet:  at java.security.AccessController.doPrivileged(Native Method)
ActionSet:  at
java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.j
ActionSet:  at java.awt.EventQueue.dispatchEvent(EventQueue.java:699)
ActionSet:  at
java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.jav
ActionSet:  at
java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:1
ActionSet:  at
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.jav
ActionSet:  at
java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
ActionSet:  at
java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
ActionSet:  at
java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

I can reproduce it when clicking find orphan with inactive plugins. I get 3
stack traces for every plugin (when loading actions.xml, dockables.xml,
services.xml)



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=2940864&group_id=588

Patches item #3609561, was opened at 2013-03-30 11:15
Message generated for change (Tracker Item Submitted) made by kerik-sf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3609561&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Eric Le Lay (kerik-sf)
Assigned to: Nobody/Anonymous (nobody)
Summary: fix for #2940864 - Exception when clicking Find orphan

Initial Comment:
fix for https://sourceforge.net/tracker/index.php?func=detail&aid=2940864&group_id=588&atid=100588

attached is a fix for the exceptions when clicking Find orphan when some plugins are disabled.

Main fix is to check PluginJAR.generateCache() if reading actions.xml, services.xml, dockables.xml has a chance to succeed before trying to do it.

It contains robustness checks (is InputStream null before parsing from it) in ServicesManager, JEditActionSet, DockableWindowFactory. They are not strictly necessary, since they don't get called anymore.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3609561&group_id=588

Bugs item #2940864, was opened at 2010-01-27 01:59
Message generated for change (Comment added) made by kerik-sf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=2940864&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: plugin manager
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Matthieu Casanova (kpouer)
Assigned to: Nobody/Anonymous (nobody)
Summary: Exception when clicking Find orphan

Initial Comment:
It seems that when trying to load actions.xml of some jars, if it doesn't exists there is an exception.
It happens a lot when doing a "find orphan" action in the Plugin Manager.
I don't think we should print a stacktrace here since it is not mandatory to have actions in a plugin

java.io.IOException: Resource not found: WhiteSpace.jar!actions.xml
	at org.gjt.sp.jedit.proto.jeditresource.PluginResURLConnection.connect(PluginResURLConnection.java:88)
	at org.gjt.sp.jedit.proto.jeditresource.Handler.openConnection(Handler.java:46)
	at java.net.URL.openConnection(URL.java:945)
	at java.net.URL.openStream(URL.java:1010)
	at org.gjt.sp.jedit.JEditActionSet.load(JEditActionSet.java:385)
	at org.gjt.sp.jedit.PluginJAR.generateCache(PluginJAR.java:1328)
	at org.gjt.sp.jedit.pluginmgr.ManagePanel$FindOrphan.actionPerformed(ManagePanel.java:1020)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
	at org.jvnet.substance.utils.RolloverButtonListener.mouseReleased(RolloverButtonListener.java:111)
	at java.awt.Component.processMouseEvent(Component.java:6263)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
	at java.awt.Component.processEvent(Component.java:6028)
	at java.awt.Container.processEvent(Container.java:2041)
	at java.awt.Component.dispatchEventImpl(Component.java:4630)
	at java.awt.Container.dispatchEventImpl(Container.java:2099)
	at java.awt.Component.dispatchEvent(Component.java:4460)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4574)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
	at java.awt.Container.dispatchEventImpl(Container.java:2085)
	at java.awt.Window.dispatchEventImpl(Window.java:2475)
	at java.awt.Component.dispatchEvent(Component.java:4460)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)


----------------------------------------------------------------------

>Comment By: Eric Le Lay (kerik-sf)
Date: 2013-03-30 11:06

Message:
This exception doesn't appear as such anymore, because
PluginResURLConnection.openStream() now silently returns null.

New exception:
(log)
ActionSet: Loading actions from
jeditresource:/UpdaterPlugin.jar!/actions.xml
(exception)
ActionSet: java.io.IOException: Stream closed
ActionSet:  at
java.io.BufferedInputStream.getInIfOpen(BufferedInputStream.java:151)
ActionSet:  at
java.io.BufferedInputStream.fill(BufferedInputStream.java:235)
ActionSet:  at
java.io.BufferedInputStream.read(BufferedInputStream.java:254)
ActionSet:  at
com.sun.org.apache.xerces.internal.impl.XMLEntityManager$RewindableInputStr
ActionSet:  at
com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEntity
ActionSet:  at
com.sun.org.apache.xerces.internal.impl.XMLVersionDetector.determineDocVers
ActionSet:  at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Co
ActionSet:  at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Co
ActionSet:  at
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:1
ActionSet:  at
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(Abstract
ActionSet:  at
org.gjt.sp.util.XMLUtilities.parseXML(XMLUtilities.java:140)
ActionSet:  at
org.gjt.sp.jedit.JEditActionSet.load(JEditActionSet.java:394)
ActionSet:  at
org.gjt.sp.jedit.PluginJAR.generateCache(PluginJAR.java:1457)
ActionSet:  at
org.gjt.sp.jedit.pluginmgr.ManagePanel$FindOrphan.actionPerformed(ManagePan
ActionSet:  at
javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2018)
ActionSet:  at
javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2341
ActionSet:  at
javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:
ActionSet:  at
javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
ActionSet:  at
javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListene
ActionSet:  at java.awt.Component.processMouseEvent(Component.java:6505)
ActionSet:  at
javax.swing.JComponent.processMouseEvent(JComponent.java:3312)
ActionSet:  at java.awt.Component.processEvent(Component.java:6270)
ActionSet:  at java.awt.Container.processEvent(Container.java:2229)
ActionSet:  at java.awt.Component.dispatchEventImpl(Component.java:4861)
ActionSet:  at java.awt.Container.dispatchEventImpl(Container.java:2287)
ActionSet:  at java.awt.Component.dispatchEvent(Component.java:4687)
ActionSet:  at
java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4832)
ActionSet:  at
java.awt.LightweightDispatcher.processMouseEvent(Container.java:4492)
ActionSet:  at
java.awt.LightweightDispatcher.dispatchEvent(Container.java:4422)
ActionSet:  at java.awt.Container.dispatchEventImpl(Container.java:2273)
ActionSet:  at java.awt.Window.dispatchEventImpl(Window.java:2719)
ActionSet:  at java.awt.Component.dispatchEvent(Component.java:4687)
ActionSet:  at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:729)
ActionSet:  at java.awt.EventQueue.access$200(EventQueue.java:103)
ActionSet:  at java.awt.EventQueue$3.run(EventQueue.java:688)
ActionSet:  at java.awt.EventQueue$3.run(EventQueue.java:686)
ActionSet:  at java.security.AccessController.doPrivileged(Native Method)
ActionSet:  at
java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.j
ActionSet:  at
java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.j
ActionSet:  at java.awt.EventQueue$4.run(EventQueue.java:702)
ActionSet:  at java.awt.EventQueue$4.run(EventQueue.java:700)
ActionSet:  at java.security.AccessController.doPrivileged(Native Method)
ActionSet:  at
java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.j
ActionSet:  at java.awt.EventQueue.dispatchEvent(EventQueue.java:699)
ActionSet:  at
java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.jav
ActionSet:  at
java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:1
ActionSet:  at
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.jav
ActionSet:  at
java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
ActionSet:  at
java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
ActionSet:  at
java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

I can reproduce it when clicking find orphan with inactive plugins. I get 3
stack traces for every plugin (when loading actions.xml, dockables.xml,
services.xml)



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=2940864&group_id=588

Plugin Bugs item #1725711, was opened at 2007-05-25 08:54
Message generated for change (Settings changed) made by malyvelky
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=1725711&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: rainman (mdrayman)
Assigned to: Jakub Holý (malyvelky)
Summary: TextAutocomplete Accept with key VK_TAB does not respond

Initial Comment:
OS: Windows XP Professional
jEdit version: 4.3pre9
Java version:  1.6.0_01
TextAutocomplete version : 0.9.4

When using the TAB key to accept a suggestion given by the TextAutocomplete plugin, the plugin does not respond and place the currently selected suggestion into the edit buffer at the cursor position.  Even explicitly specifying VK_TAB in the "Accept with key" option under Plugin Options for TextAutocomplete still does not work either.

Reproduce this bug by simply enabling the plugin and start typing a word that already exists in the buffer allowing the plugin to bring up the autocomplete popup, select one of the suggestions and hit the TAB key.  The plugin will not respond, you will have to hit the ENTER key.



----------------------------------------------------------------------

>Comment By: Jakub Holý (malyvelky)
Date: 2013-03-30 07:19

Message:
If you had send a copy of the bug to myself as suggested in the plugin's
Help documentation, this could have been solved much earlier :-)

This is actually an issue in jEdit itself, I have opened
https://sourceforge.net/tracker/?func=detail&aid=3609550&group_id=588&atid=100588
for it. However I have created a workaround in TextAutocomplete, which is
available in the version 1.0.0 scheduled for release soon [1].

[1]
https://sourceforge.net/tracker/?func=detail&aid=3609551&group_id=588&atid=625093

----------------------------------------------------------------------

Comment By: Matteo Sasso (matteo-sasso)
Date: 2012-04-18 07:17

Message:
I confirm this bug happens on jEdit v4.5.1 running under Windows, Java
v1.6.0_26.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=1725711&group_id=588

Plugin Central Submission item #3609551, was opened at 2013-03-30 07:16
Message generated for change (Tracker Item Submitted) made by malyvelky
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3609551&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jakub Holý (malyvelky)
Assigned to: Nobody/Anonymous (nobody)
Summary: TextAutocomplete 1.0.0

Initial Comment:

    Source: Source code is in SVN with the tag RELEASE-1.0.0
    Announcement: Fix to make it possible to accept a completion with the TAB key.
    Requires Java 1.5
    Requires jEdit 04.03.15.00
    
    Short Description: It's pretty similar to the jEdit's function "Complete Word" but it's automatic, you don't need to press any key to invoke the list of completions.
    
    Long Description: <p>TextAutocomplete collects "words" in the current buffer and those that you type and offers you automatically a list of possible completions as you type a new word. It's pretty similar to the jEdit's function "Complete Word" but it's automatic, you don't need to press any key to invoke the list of completions. The plugin was inspired by a similar functionality in OpenOffice.org.</p>

<p>The plugin is configurable, you can define what a "word" is, what words (not) to remember etc. - see the docs. It's also possible to modify manually the list of remembered words.</p>

<p>You have to start the autocompletion for every buffer where you want it.</p>

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3609551&group_id=588

Bugs item #3609550, was opened at 2013-03-30 07:02
Message generated for change (Tracker Item Submitted) made by malyvelky
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=3609550&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: keyboard / mouse
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jakub Holý (malyvelky)
Assigned to: Nobody/Anonymous (nobody)
Summary: CompletionPopup should accept TAB for completion selection

Initial Comment:
Summary: call "list.setFocusTraversalKeysEnabled(false);" in the constructor of  org.gjt.sp.jedit.gui.CompletionPopup to make it possible to use TAB for completion selection, in the same way as ENTER.

This currently doesn't work because TAB is used for component traversal by the focus subsystem and is thus never passed to the JList.

Reference: http://docs.oracle.com/javase/tutorial/uiswing/events/keylistener.html (read the "Version note"

Env.: jEdit 5.0.0, Oracle Java 1.7.0:15 on OS X (though this should apply since JDK 1.4 and to all platforms)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=3609550&group_id=588

Plugin Bugs item #3440290, was opened at 2011-11-19 09:43
Message generated for change (Comment added) made by malyvelky
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=3440290&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Jarek Czekalski (jarekczek)
Assigned to: Townsfolk (elberry)
Summary: TextAutocomplete build.xml inconsistent with plugin-build

Initial Comment:
TextAutocomplete uses its own build.xml, not importing plugin-build.xml. So when I run "build" target, I don't get jar in my install.dir directory. That's what I expect when launching "build" target.

----------------------------------------------------------------------

>Comment By: Jakub Holý (malyvelky)
Date: 2013-03-30 05:51

Message:
Fixed in
http://jedit.svn.sourceforge.net/viewvc/jedit?view=revision&revision=22901

----------------------------------------------------------------------

Comment By: Townsfolk (elberry)
Date: 2011-11-28 23:42

Message:
I'll take a look at the build file to see what I can do to get it up to
date, but what do you mean Daily builds works around this inconsistency?
There isn't a Textautocomplete build in the daily builds.

----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2011-11-28 23:42

Message:
TextAutoComplete is not in the Daily Builds.


----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2011-11-28 23:36

Message:
What bothers me is that daily builds somehow workaround this inconsistency.
If one changes build.xml they may break. But probably it is a little
problem and if it really occures, during daily build, someone will fix it
then.

----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2011-11-28 12:46

Message:
If you know how to make it consistent with other plugins, feel free to
change it yourself and commit.
Otherwise, assigning to elberry.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=3440290&group_id=588

Plugin Bugs item #2228982, was opened at 2008-11-06 02:13
Message generated for change (Comment added) made by malyvelky
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=2228982&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Pending
Resolution: None
Priority: 5
Private: No
Submitted By: admirau (admirau)
>Assigned to: Jakub Holý (malyvelky)
Summary: TextAutocomplete: long loading

Initial Comment:
I'm very uncomfortable because starting autocomplete takes very long time.
For new, empty buffer it is about 6 seconds.
That disqualifies using option "Start autom. for new buffers".

Maybe it is some way to speed it up?
Preload plugin at jEdit (or jEdit server) startup?

What does macro Auto_autocomplete.bsh do?

(Vista, Limited user account, JDK 1.6_10, TextAutocomplete 0.9.8b form plugin central) 

----------------------------------------------------------------------

>Comment By: Jakub Holý (malyvelky)
Date: 2013-03-30 03:21

Message:
Do you still experience the problem? It works just fine for me, i.e. starts
immediately for an empty buffer.

> What does macro Auto_autocomplete.bsh do?

I have no such macro, where did you get it?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=2228982&group_id=588

Plugin Bugs item #1725711, was opened at 2007-05-25 08:54
Message generated for change (Settings changed) made by malyvelky
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=1725711&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: rainman (mdrayman)
>Assigned to: Jakub Holý (malyvelky)
Summary: TextAutocomplete Accept with key VK_TAB does not respond

Initial Comment:
OS: Windows XP Professional
jEdit version: 4.3pre9
Java version:  1.6.0_01
TextAutocomplete version : 0.9.4

When using the TAB key to accept a suggestion given by the TextAutocomplete plugin, the plugin does not respond and place the currently selected suggestion into the edit buffer at the cursor position.  Even explicitly specifying VK_TAB in the "Accept with key" option under Plugin Options for TextAutocomplete still does not work either.

Reproduce this bug by simply enabling the plugin and start typing a word that already exists in the buffer allowing the plugin to bring up the autocomplete popup, select one of the suggestions and hit the TAB key.  The plugin will not respond, you will have to hit the ENTER key.



----------------------------------------------------------------------

Comment By: Matteo Sasso (matteo-sasso)
Date: 2012-04-18 07:17

Message:
I confirm this bug happens on jEdit v4.5.1 running under Windows, Java
v1.6.0_26.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=1725711&group_id=588

Plugin Bugs item #1478373, was opened at 2006-04-28 05:44
Message generated for change (Comment added) made by malyvelky
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=1478373&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Andrea Azzini (azzo666)
>Assigned to: Jakub Holý (malyvelky)
Summary: textAutocomplete crashes jedit

Initial Comment:
When I close with the X button the popup where there
are the words parsed by textAutocomplete plugin, jEdit
crashes

----------------------------------------------------------------------

>Comment By: Jakub Holý (malyvelky)
Date: 2013-03-30 03:15

Message:
I could not reproduce the problem. Also, the bug is very old, jEdit has
been update many times sicne that.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=1478373&group_id=588

Patches item #3609469, was opened at 2013-03-29 07:12
Message generated for change (Tracker Item Submitted) made by thomasmey
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3609469&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Meyer (thomasmey)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix mode loading for temporary buffers

Initial Comment:
Don't load mode for temporary buffers. This speeds up HyperSearch greatly for the non-wholeWord search case. For the wholeWord case explicitly set the mode in the HyperSearch.

Proposed patch attached.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3609469&group_id=588

Hi, I'm not sure but I suppose it is because whole word search need
the wordBreakChars information to work.


2013/3/28 Thomas Meyer <tho...@we...>

> Hi,
>
> this commit has a huge performance impact on HyperSearch:
>
> commit c338d320441d359a0cf1101708611ba7a6ddfae3
> Author: Matthieu Casanova <kp...@us...>
> Date:   Mon Feb 28 11:38:01 2011 +0000
>
>     A temporary buffer was not settings it's edit mode, breaking the
> hypersearch request since new feature that search for whole word
>
> diff --git a/org/gjt/sp/jedit/Buffer.java b/org/gjt/sp/jedit/Buffer.java
> index 0c5dcbe..6c37629 100644
> --- a/org/gjt/sp/jedit/Buffer.java
> +++ b/org/gjt/sp/jedit/Buffer.java
> @@ -253,7 +253,9 @@ public class Buffer extends JEditBuffer
>                                 undoMgr.setLimit(jEdit.getIntegerProperty(
>                                         "buffer.undoCount",100));
>
> -                               if(!getFlag(TEMPORARY))
> +                               if (getFlag(TEMPORARY))
> +                                       setMode();
> +                               else
>                                         finishLoading();
>
>                                 setLoading(false);
>
> There is also a second commit which add a not so helpful comment:
>
> commit d22adc97813ba7f7fed7a1e5f6a155fa5427bb43
> Author: Matthieu Casanova <kp...@us...>
> Date:   Mon Feb 28 11:49:36 2011 +0000
>
>     added comments
>
> diff --git a/org/gjt/sp/jedit/Buffer.java b/org/gjt/sp/jedit/Buffer.java
> index 6c37629..ea91471 100644
> --- a/org/gjt/sp/jedit/Buffer.java
> +++ b/org/gjt/sp/jedit/Buffer.java
> @@ -253,6 +253,10 @@ public class Buffer extends JEditBuffer
>                                 undoMgr.setLimit(jEdit.getIntegerProperty(
>                                         "buffer.undoCount",100));
>
> +                               // If the buffer is temporary, we don't
> need to
> +                               // call finishLoading() because it sets
> the FoldHandler
> +                               // and reload markers. But we always need
> to set the edit
> +                               // mode that is necessary for HyperSearch
> on directories
>                                 if (getFlag(TEMPORARY))
>                                         setMode();
>                                 else
>
>
> So I guess, the idea was to fix the whole word search. Does anybody have
> more infos on this change? Bug id? Patch id?
>
> I usually don't use the whole word feature, but as I said above change
> had a huge impact on all other HyperSearches as it loops for every file
> in the search list all 180 or so mode files, which doesn't short circuit
> for the first hit...
>
> If the loaded mode for the buffer (why?) is really necessary for the
> whole word search, then only load the mode file if the whole word search
> flag is set, or exclusivity set the mode file in the HyperSearchRequest
> for the temporary buffer, or something like that.
>
> The current code feels wrong and is slow.
>
> Ideas, answers and feedback welcome!
>
> with kind regards
> thomas
>
>
>
> ------------------------------------------------------------------------------
> Own the Future-Intel&reg; Level Up Game Demo Contest 2013
> Rise to greatness in Intel's independent game demo contest.
> Compete for recognition, cash, and the chance to get your game
> on Steam. $5K grand prize plus 10 genre and skill prizes.
> Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
> --
> -----------------------------------------------
> jEdit Developers' List
> jEd...@li...
> https://lists.sourceforge.net/lists/listinfo/jedit-devel
>

Great idea. I have been annoyed by pressing Utilities -> Global Options...
and getting the Plugin Options tab selected.
Shlomy


On Tue, Mar 19, 2013 at 7:00 PM, Alan Ezust <ala...@gm...> wrote:

> Currently, we have actions for "global-options" as well as "options".
> The first always selects the global options tab, while the second will
> restore whichever tab you were on last time.
> The first is currently hidden from the menus, and only available via
> shortcut options.
>
> There is disagreement amongst the devs as to which action should appear in
> the utilities dropdown menu. It seems silly to have both in it.
>
> Changing global options to options it has made some of the docs and
> tooltips invalid.
>
> I am thinking of changing it *BACK* in the menu to global-options, while
> leaving the toolbar button
> as it is, which is currently bound to the "options" action.
>
> This way, both actions are available from the GUI, and
> the toolbar button brings back whatever option pane you were working on,
> while the Global Options action is back in the menu as it always was.
>
> Any opinions on this proposed change?
>
>
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_mar
> --
> -----------------------------------------------
> jEdit Developers' List
> jEd...@li...
> https://lists.sourceforge.net/lists/listinfo/jedit-devel
>
>

Hi,

this commit has a huge performance impact on HyperSearch:

commit c338d320441d359a0cf1101708611ba7a6ddfae3
Author: Matthieu Casanova <kp...@us...>
Date:   Mon Feb 28 11:38:01 2011 +0000

    A temporary buffer was not settings it's edit mode, breaking the hypersearch request since new feature that search for whole word

diff --git a/org/gjt/sp/jedit/Buffer.java b/org/gjt/sp/jedit/Buffer.java
index 0c5dcbe..6c37629 100644
--- a/org/gjt/sp/jedit/Buffer.java
+++ b/org/gjt/sp/jedit/Buffer.java
@@ -253,7 +253,9 @@ public class Buffer extends JEditBuffer
                                undoMgr.setLimit(jEdit.getIntegerProperty(
                                        "buffer.undoCount",100));
 
-                               if(!getFlag(TEMPORARY))
+                               if (getFlag(TEMPORARY))
+                                       setMode();
+                               else
                                        finishLoading();
 
                                setLoading(false);

There is also a second commit which add a not so helpful comment:

commit d22adc97813ba7f7fed7a1e5f6a155fa5427bb43
Author: Matthieu Casanova <kp...@us...>
Date:   Mon Feb 28 11:49:36 2011 +0000

    added comments

diff --git a/org/gjt/sp/jedit/Buffer.java b/org/gjt/sp/jedit/Buffer.java
index 6c37629..ea91471 100644
--- a/org/gjt/sp/jedit/Buffer.java
+++ b/org/gjt/sp/jedit/Buffer.java
@@ -253,6 +253,10 @@ public class Buffer extends JEditBuffer
                                undoMgr.setLimit(jEdit.getIntegerProperty(
                                        "buffer.undoCount",100));
 
+                               // If the buffer is temporary, we don't need to
+                               // call finishLoading() because it sets the FoldHandler
+                               // and reload markers. But we always need to set the edit
+                               // mode that is necessary for HyperSearch on directories
                                if (getFlag(TEMPORARY))
                                        setMode();
                                else


So I guess, the idea was to fix the whole word search. Does anybody have
more infos on this change? Bug id? Patch id?

I usually don't use the whole word feature, but as I said above change
had a huge impact on all other HyperSearches as it loops for every file
in the search list all 180 or so mode files, which doesn't short circuit
for the first hit...

If the loaded mode for the buffer (why?) is really necessary for the
whole word search, then only load the mode file if the whole word search
flag is set, or exclusivity set the mode file in the HyperSearchRequest
for the temporary buffer, or something like that.

The current code feels wrong and is slow.

Ideas, answers and feedback welcome!

with kind regards
thomas

Plugin Central Submission item #3609339, was opened at 2013-03-28 02:33
Message generated for change (Comment added) made by elberry
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3609339&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Matthieu Casanova (kpouer)
>Assigned to: Townsfolk (elberry)
Summary: Highlight 1.9.12

Initial Comment:
{{{ Highlight 1.9.12
    Source: https://jedit.svn.sourceforge.net/svnroot/jedit/plugins/Highlight/tags/Highlight-1.9.12
    Announcement: -Added an option to choose round corner or not
        -Fixed highlighter ignoring extra line spacing
    Requires Java 1.6
    Requires jEdit 04.05.99.00
    
    Short Description: Highlight is a visual plugin that will highlight words (or matched regexp) with different colors.
    
    Long Description: This plugin is a visual plugin that will highlight
words (or matched regexp) with different colors.
 }}}

----------------------------------------------------------------------

>Comment By: Townsfolk (elberry)
Date: 2013-03-28 12:15

Message:
Tested with jEdit 4.5.2

----------------------------------------------------------------------

Comment By: Townsfolk (elberry)
Date: 2013-03-28 12:15

Message:
Packaged and released to plugin central and plugin manager.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3609339&group_id=588

Plugin Central Submission item #3609339, was opened at 2013-03-28 02:33
Message generated for change (Tracker Item Submitted) made by kpouer
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3609339&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Matthieu Casanova (kpouer)
Assigned to: Nobody/Anonymous (nobody)
Summary: Highlight 1.9.12

Initial Comment:
{{{ Highlight 1.9.12
    Source: https://jedit.svn.sourceforge.net/svnroot/jedit/plugins/Highlight/tags/Highlight-1.9.12
    Announcement: -Added an option to choose round corner or not
        -Fixed highlighter ignoring extra line spacing
    Requires Java 1.6
    Requires jEdit 04.05.99.00
    
    Short Description: Highlight is a visual plugin that will highlight words (or matched regexp) with different colors.
    
    Long Description: This plugin is a visual plugin that will highlight
words (or matched regexp) with different colors.
 }}}

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3609339&group_id=588

Plugin Central Submission item #3609082, was opened at 2013-03-25 18:57
Message generated for change (Comment added) made by elberry
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3609082&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Alan Ezust (ezust)
>Assigned to: Townsfolk (elberry)
Summary: FastOpen 2.5.1

Initial Comment:
{{{ FastOpen 2.5.1
    Source: Source code is in SVN with the tag FastOpen-2.5.1
    Announcement: FR #3580223: If the thing to search for has a file separator character, search full path instead of just filename. 
    Requires Java 1.6
    Requires jEdit 05.00.01.00
    Optional plugins: 
        Project Viewer 3.5.0 (projectviewer.ProjectPlugin)
    
    Short Description: FastOpen is a plugin designed to quickly open any file in the current project by just typing in some characters of the filename you want to open.
    
    Long Description: <html>
<p> FastOpen is a plugin designed to quickly open any file
in the current project by just typing in some 
characters of the filename you want to open. Besides
quickly opening any file, it has a lot of features like
switching between projects, indicating invalid
filenames, opening non-project files, opening files
from "Recent List" and more! </p>
</html>
 }}}

----------------------------------------------------------------------

>Comment By: Townsfolk (elberry)
Date: 2013-03-27 11:37

Message:
Tested with jEdit 5.0.0 final, ProjectViewer 3.5.1

----------------------------------------------------------------------

Comment By: Townsfolk (elberry)
Date: 2013-03-27 11:37

Message:
Released to Plugin Central.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3609082&group_id=588

Plugin Central Submission item #3608731, was opened at 2013-03-21 09:40
Message generated for change (Comment added) made by elberry
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3608731&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: yohannmartineau (yohannmartineau)
Assigned to: Townsfolk (elberry)
Summary: CscopeFinder 0.6

Initial Comment:
{{{ CscopeFinder 0.6
    Source: Source code is in SVN with the tag 0.6
    Announcement: * Release 0.6
            - applied patch 3025115: Fix escape behavior in pop-up chooser (yohannmartineau)
    Requires Java 1.5
    Requires jEdit 04.05.99.00
    
    Short Description: CscopeFinder adds rapid code searching using Cscope index files.
    
    Long Description: <p>CscopeFinder is a plugin for the jEdit code editor that gives
jEdit the ability to use Cscope index files for rapid searching.</p>
 }}}

----------------------------------------------------------------------

>Comment By: Townsfolk (elberry)
Date: 2013-03-27 11:28

Message:
Tested on jEdit 4.5.2

----------------------------------------------------------------------

Comment By: Townsfolk (elberry)
Date: 2013-03-27 11:28

Message:
Released to Plugin Central.

----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2013-03-26 16:37

Message:
Committed 22893 to 0.6 branch. Now the build runs the userdocs target, the
userdocs target runs rst2html, and you need to apt-get install
python-docutils to build it.


----------------------------------------------------------------------

Comment By: Townsfolk (elberry)
Date: 2013-03-26 16:24

Message:
I'm not seeing the documentation. There's no index.html file, and none
being created during the build process.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3608731&group_id=588

Plugin Central Submission item #3609081, was opened at 2013-03-25 18:53
Message generated for change (Comment added) made by elberry
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3609081&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Alan Ezust (ezust)
>Assigned to: Townsfolk (elberry)
Summary: SshConsole 1.0.6

Initial Comment:
{{{ SshConsole 1.0.6
    Source: Source code is in SVN with the tag SshConsole-1.0.6
    Announcement: 
 <ul>
   <li> Fix #3604654: NPE when changing to invalid folder. </li>
   <li> Fix #3604790: Initial connect when opening a project </li>
 </ul> 
    Requires Java 1.6
    Requires jEdit 05.00.99.00
    Required plugins: 
        Console 5.1 (console.ConsolePlugin)
        ErrorList 2.1 (errorlist.ErrorListPlugin)
        FTP 1.0.2 (ftp.FtpPlugin)
    
    Short Description: Allows you to issue compile commands remotely via ssh in the same location as the sftp:// file you are editing, and parses the output for errors in ErrorList.
    
    Long Description: <html>
<p>SshConsole is an extension of the FTP, Console and ErrorList plugins. SshConsole is configured to execute commands on the same host, and in the same directory, as the directory you are currently browsing in the FSB or editing in jEdit via <tt>sftp://</tt>. It uses Console to parse the output for errors to show in ErrorList. This makes it easier to compile remote files and quickly jump to the errors. 
</p>
</html>
 }}}

----------------------------------------------------------------------

>Comment By: Townsfolk (elberry)
Date: 2013-03-26 16:47

Message:
Tested with Console 5.1.1, and FTP 1.0.3

----------------------------------------------------------------------

Comment By: Townsfolk (elberry)
Date: 2013-03-26 16:47

Message:
Released to Plugin Central.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3609081&group_id=588

Plugin Central Submission item #3608731, was opened at 2013-03-21 09:40
Message generated for change (Comment added) made by ezust
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3608731&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: yohannmartineau (yohannmartineau)
Assigned to: Townsfolk (elberry)
Summary: CscopeFinder 0.6

Initial Comment:
{{{ CscopeFinder 0.6
    Source: Source code is in SVN with the tag 0.6
    Announcement: * Release 0.6
            - applied patch 3025115: Fix escape behavior in pop-up chooser (yohannmartineau)
    Requires Java 1.5
    Requires jEdit 04.05.99.00
    
    Short Description: CscopeFinder adds rapid code searching using Cscope index files.
    
    Long Description: <p>CscopeFinder is a plugin for the jEdit code editor that gives
jEdit the ability to use Cscope index files for rapid searching.</p>
 }}}

----------------------------------------------------------------------

>Comment By: Alan Ezust (ezust)
Date: 2013-03-26 16:37

Message:
Committed 22893 to 0.6 branch. Now the build runs the userdocs target, the
userdocs target runs rst2html, and you need to apt-get install
python-docutils to build it.


----------------------------------------------------------------------

Comment By: Townsfolk (elberry)
Date: 2013-03-26 16:24

Message:
I'm not seeing the documentation. There's no index.html file, and none
being created during the build process.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3608731&group_id=588

Plugin Central Submission item #3608731, was opened at 2013-03-21 09:40
Message generated for change (Comment added) made by elberry
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3608731&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Pending
Resolution: None
Priority: 5
Private: No
Submitted By: yohannmartineau (yohannmartineau)
>Assigned to: Townsfolk (elberry)
Summary: CscopeFinder 0.6

Initial Comment:
{{{ CscopeFinder 0.6
    Source: Source code is in SVN with the tag 0.6
    Announcement: * Release 0.6
            - applied patch 3025115: Fix escape behavior in pop-up chooser (yohannmartineau)
    Requires Java 1.5
    Requires jEdit 04.05.99.00
    
    Short Description: CscopeFinder adds rapid code searching using Cscope index files.
    
    Long Description: <p>CscopeFinder is a plugin for the jEdit code editor that gives
jEdit the ability to use Cscope index files for rapid searching.</p>
 }}}

----------------------------------------------------------------------

>Comment By: Townsfolk (elberry)
Date: 2013-03-26 16:24

Message:
I'm not seeing the documentation. There's no index.html file, and none
being created during the build process.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=625093&aid=3608731&group_id=588