attal-devel Mailing List for Attal : Lords of doom

Oh... I didn't know make was working like that...
I'll check it and if it is ok, it seems indeed a good idea

> I would like to suggest a modification for the coding 
> guidelines. I saw in the 
> files that local includes do include the path to the file. I 
> should resume 
> the actual policy to this example :
> 
> file libClient/foo.cpp:
> ---
> 
> #include <qpixmaps.h>
> #include "libCommon/bar.h"
> #include "libClient/foobar.h"
> 
> ---
> 
> make will be confused by this. If foobar.h is modified, 
> foo.cpp won't be 
> recompiled. The policy should be:
> 
> file libClient/foo.cpp:
> ---
> 
> #include <qstring.h>
> #include <libCommon/bar.h>
> #include "foobar.h"
> 
> --
> 
> This way, make will find the modified timestamp and build 
> fine. The second 
> include is not a local include. At compilation time, it is 
> found by the -I..
> 
> Raphael
> 
> 
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Attal-devel mailing list
> Att...@li...
> https://lists.sourceforge.net/lists/listinfo/attal-devel
> 
###########################################

This message has been scanned by F-Secure Anti-Virus for Microsoft Exchange.
For more information, connect to http://www.F-Secure.com/

I've just added sound support in attal (using SDL) !!
And it seems to work well :)
See config.pro for enabling/disabling sound support
You will need SDL and SDL_mixer to be installed.

(if you are using anonymous CVS access it may be updated only tomorrow...)

Of course you will have to update the "theme" part for getting the musics.

Pascal
###########################################

This message has been scanned by F-Secure Anti-Virus for Microsoft Exchange.
For more information, connect to http://www.F-Secure.com/

Hi all,

I would like to suggest a modification for the coding guidelines. I saw in the 
files that local includes do include the path to the file. I should resume 
the actual policy to this example :

file libClient/foo.cpp:
---

#include <qpixmaps.h>
#include "libCommon/bar.h"
#include "libClient/foobar.h"

---

make will be confused by this. If foobar.h is modified, foo.cpp won't be 
recompiled. The policy should be:

file libClient/foo.cpp:
---

#include <qstring.h>
#include <libCommon/bar.h>
#include "foobar.h"

--

This way, make will find the modified timestamp and build fine. The second 
include is not a local include. At compilation time, it is found by the -I..

Raphael

On Monday 15 September 2003 10:31, AUDOUX Pascal wrote:
> Well, as I said before, you only have to change "IMAGE_PATH" and
> "DATA_PATH", not
> patching the entire applications and libs :-))

I don't agree with this :) IMAGE_PATH and DATA_PATH do alter the paths found 
after the theme has been selected, but if you want to let the user choose a 
theme, you can't change them ... IMAGE_PATH and DATA_PATH are relative to the 
selected theme dir, what I need is to set a default directory where the 
themes dirs can be found :)

> Btw the pb of this method is that it uses /usr/share/attal as default path
> and I'm not sure it is the best for everyone...

I agree with this :)

> I thought you will use the -lqwindowsstyle ???

I can't. If I do this, I'll have to link against a plugin, and that's not very 
clean.

> I will do it as soon as I have a few free time...
> Well, if you can't wait, just do it yourself with only numbers...

I'll do it :o)

> Well, we are needing developpers so it will be great if you join us...
> Have you some things you would like to do in particular ?

I'm looking the code for the moment ...

> Otherwise, usually when there is a new developper
> we start by doing small things, for example some widgets in the editors, or
> in some specific part of the game
> and then bigger things or more complex and so on.
> (the goal is to discover the architecture step by step :) )

Yes :) The number of classes and how they are used is not easy to guess.

> I think the best is to have a chat through icq or irc one evening... tell
> me when you can (if possible) :)

I'm online on freenode with the nick rafou, and you can find me on icq with 
the uin 1479312.

Raphael

> On Friday 05 September 2003 17:40, AUDOUX Pascal wrote:
> > ok, I'm waiting for your code :)
> > (the two QString IMAGE_PATH and DATA_PATH are in 
> client/main.cpp (for the
> > client)... seems here a good place for changing them
> > using environment var for example)
> 
> I did it the ugly way ... The apps do a QDir::setCurrent() to 
> /usr/share/attal 
> unless an option specifying the dir is passed by command 
> line. This allows me 
> to avoid patching the entire applications and libs.
> 
Well, as I said before, you only have to change "IMAGE_PATH" and
"DATA_PATH", not
patching the entire applications and libs :-))
Btw the pb of this method is that it uses /usr/share/attal as default path
and I'm not sure it is the best
for everyone...

> > > The plugin conversion of AttalStyle is not difficult to do.
> 
> It was more difficult than I thought. Because AttalStyle 
> inherits from 
> QWindowsStyle, I can't build it as a plugin, because then the 
> .so file doen't 
> have access to the code of qwindowsstyle.cpp. I'll have to 
> modify AttalStyle 
> to inherit from QStyle, and import the code from QWindowsStyle.
I thought you will use the -lqwindowsstyle ???

> I don't know. An temporary idea was to replace the lords with 
> images generated 
> with a number. That's not very nice, but It allows the 
> package to enter 
> debian.
I will do it as soon as I have a few free time...
Well, if you can't wait, just do it yourself with only numbers...

> I had a look at the code of Attal, and I'd be willing to give 
> some help, as 
> I'm myself a Qt developer. But this is independent of the 
> debian packaging :)
> 
Well, we are needing developpers so it will be great if you join us...
Have you some things you would like to do in particular ?

Otherwise, usually when there is a new developper
we start by doing small things, for example some widgets in the editors, or
in some specific part of the game
and then bigger things or more complex and so on.
(the goal is to discover the architecture step by step :) )

I think the best is to have a chat through icq or irc one evening... tell me
when you can (if possible) :)
###########################################

This message has been scanned by F-Secure Anti-Virus for Microsoft Exchange.
For more information, connect to http://www.F-Secure.com/

On Friday 05 September 2003 17:40, AUDOUX Pascal wrote:
> ok, I'm waiting for your code :)
> (the two QString IMAGE_PATH and DATA_PATH are in client/main.cpp (for the
> client)... seems here a good place for changing them
> using environment var for example)

I did it the ugly way ... The apps do a QDir::setCurrent() to /usr/share/attal 
unless an option specifying the dir is passed by command line. This allows me 
to avoid patching the entire applications and libs.

I said :
> > The plugin conversion of AttalStyle is not difficult to do.

It was more difficult than I thought. Because AttalStyle inherits from 
QWindowsStyle, I can't build it as a plugin, because then the .so file doen't 
have access to the code of qwindowsstyle.cpp. I'll have to modify AttalStyle 
to inherit from QStyle, and import the code from QWindowsStyle.

> Tell me what do you think I have to do exactly :)

Put the GPL in the archive, stating the images are GPLed. Like a licence or 
copying file.

> Well, there is a pb only with some faces of lords (someone tells me that he
> did them and tells me he was allowing me to use them all but it seems that
> it is not the case and that some are part of games...) We need to remove
> them and replace it by real free ones (if you have some ideas...).
> I think no other pictures are not free

I don't know. An temporary idea was to replace the lords with images generated 
with a number. That's not very nice, but It allows the package to enter 
debian.

The debian package is almost ready now. It builds and work, except for the 
AttalStyle plugin. This one will be solved this week end. I will upload it to 
debian as soon as I can fetch a real free theme archive from you. I can't 
just modify the images myself, because the source archive is included in the 
debian distribution along with a diff. The diff includes my changes, and the 
source file is the upstream files unmodified. Putting these images on a 
debian server, even if they are not included in the package, is a copyright 
violation we can't afford :p

I had a look at the code of Attal, and I'd be willing to give some help, as 
I'm myself a Qt developer. But this is independent of the debian packaging :)

Raphael

> > About Debian, someone give us some details about 
> compilation under Woody (I
> > don't know if you have seen the Install.debian file 
> provided with the
> > sources). Eventually you may write it (prophyle at gmx dot 
> de) for sharing
> > experiences.
> 
> I saw the install.debian file, but a legacy installation 
> needs more things to 
> be done. The trick to link against QWindowsStyle is a nice one :)
:-)


> > For the theme (data and pictures) the game request to be launch in a
> > directory in which it can found a subfolder "themes" with the theme
> > inside... may be we should improve this for setting the 
> path to the theme
> > in an other way (for example using an evironnement variable 
> or something
> > else...) if you have an idea, just tell it!
> 
> An environment variable could be fine, but we must be able to 
> change the 
> default at compilation time. conf.h seems to be the good 
> place for that. I'll 
> make the modifications, then submit them to you if you want 
> to include them 
> upstream.
ok, I'm waiting for your code :)
(the two QString IMAGE_PATH and DATA_PATH are in client/main.cpp (for the
client)... seems here a good place for changing them
using environment var for example)

> Making AttalStyle a plugin will allow it to be used outside of the 
> application :) Nevertheless, it has to be done : With Qt3, styles are 
> compiled as plugins, and loaded at run time with :
> 
>  QApplication::setStyle( QStyleFactory::create( "AttalStyle" ) );
> 
> The plugin conversion of AttalStyle is not difficult to do. 
> I'll do it and 
> send you the patch if you want to use it upstream.
> 
> However, I have a blocking issue with the themes. Only free 
> softwares and 
> documents can be packaged in Debian, and the themes does not comply.
> First, you say the images are GPLed on the website, but this 
> is not stated in 
> the distributed file. This is a *must* for the archive to be 
> accepted by the 
> debian ftp-masters.
Tell me what do you think I have to do exactly :)

> Second, it seems some images from the themes come from third 
> party sources, 
> like the game Baldur's gate. This means you don't have the 
> rights to use them 
> or distribute them. Nor do I the right to include them within 
> a debian 
> package.
Well, there is a pb only with some faces of lords (someone tells me that he
did them and tells me he was allowing me to use them all but it seems that
it is not the case and that some are part of games...) We need to remove
them and replace it by real free ones (if you have some ideas...).
I think no other pictures are not free

> The first issue is not a difficult one, but I understand the 
> second is.
yes and I forgot this problem... well, we should (remember of it and) fix it
before next release
###########################################

This message has been scanned by F-Secure Anti-Virus for Microsoft Exchange.
For more information, connect to http://www.F-Secure.com/

Hi,

> About Debian, someone give us some details about compilation under Woody (I
> don't know if you have seen the Install.debian file provided with the
> sources). Eventually you may write it (prophyle at gmx dot de) for sharing
> experiences.

I saw the install.debian file, but a legacy installation needs more things to 
be done. The trick to link against QWindowsStyle is a nice one :)

> For the theme (data and pictures) the game request to be launch in a
> directory in which it can found a subfolder "themes" with the theme
> inside... may be we should improve this for setting the path to the theme
> in an other way (for example using an evironnement variable or something
> else...) if you have an idea, just tell it!

An environment variable could be fine, but we must be able to change the 
default at compilation time. conf.h seems to be the good place for that. I'll 
make the modifications, then submit them to you if you want to include them 
upstream.

> Btw, this part is a very old code and it requires to be modified (it was
> made just when style were introduced in Qt and it has evolved a lot
> since... may be we should rewrite this part and it will also solve this pb
> ?)

Making AttalStyle a plugin will allow it to be used outside of the 
application :) Nevertheless, it has to be done : With Qt3, styles are 
compiled as plugins, and loaded at run time with :

 QApplication::setStyle( QStyleFactory::create( "AttalStyle" ) );

The plugin conversion of AttalStyle is not difficult to do. I'll do it and 
send you the patch if you want to use it upstream.

However, I have a blocking issue with the themes. Only free softwares and 
documents can be packaged in Debian, and the themes does not comply.

First, you say the images are GPLed on the website, but this is not stated in 
the distributed file. This is a *must* for the archive to be accepted by the 
debian ftp-masters.

Second, it seems some images from the themes come from third party sources, 
like the game Baldur's gate. This means you don't have the rights to use them 
or distribute them. Nor do I the right to include them within a debian 
package.

The first issue is not a difficult one, but I understand the second is.

Raphael

Hi :)

The mail I sent Gilles bounced back to me. It seems attal-thegame.com =
does not=20
deliver mails for the moment. I forward it here.

Raphael

----------  Forwarded Message  ----------

Subject: Attal et Debian
Date: Tuesday 02 September 2003 13:21
From: Raphael Goulais <ra...@ni...>
To: mi...@at...

Bonjour,

Tout d'abord, f=E9licitation pour le travail effectu=E9 sur Attal. Je =
trouve le
jeu tr=E8s prometteur, malgr=E9 quelques petites difficult=E9s que j'ai =
pu
rencontrer. Je suis en train de pr=E9parer un paquet Debian pour =
celui-ci. Il
ne tardera donc pas =E0 faire son entr=E9e dans la version *unstable* =
de Debian.
J'=E9tablis donc ici un premier contact :o)

Le travail d'un mainteneur debian consiste =E0 *packager* l'application =
afin
qu'elle soit conforme =E0 la politique du syst=E8me, et que le paquet =
cohabite
sans difficult=E9s avec les autres logiciels install=E9s. Ce sera une =
partie de
mon travail.

Une autre partie du travail du mainteneur est de recevoir les rapports =
de
 bugs des utilisateurs et de les qualifier. Lorsque ces bugs concernent
 l'upstream (vous), je me chargerai de vous les relayer.

J'espere que l'int=E9gration d'Attal dans le projet Debian vous =
apportera un
petit plus, que se soit par la diffusion ou la remont=E9e =
d'information.

Cordialement,

Raphael

-------------------------------------------------------

Thanks for this mail (well, Gilles is on vacation this week, I think...)
A debian package would be a good thing!

About Debian, someone give us some details about compilation under Woody (I
don't know if you have seen the Install.debian file provided with the
sources). Eventually you may write it (prophyle at gmx dot de) for sharing
experiences.

For the theme (data and pictures) the game request to be launch in a
directory in which it can found a subfolder "themes" with the theme
inside... may be we should improve this for setting the path to the theme in
an other way (for example using an evironnement variable or something
else...) if you have an idea, just tell it!
The pb of the qwindowstyle is strange... it seems that under debian we need
to add another library at link (seems simplier than modifying code for using
plug-in and so on...)
Btw, this part is a very old code and it requires to be modified (it was
made just when style were introduced in Qt and it has evolved a lot since...
may be we should rewrite this part and it will also solve this pb ?)

> -----Message d'origine-----
> De : Raphael Goulais [mailto:ra...@ni...]
> Envoye : mercredi 3 septembre 2003 10:40
> A : att...@li...
> Objet : [Attal-devel] Attal and Debian
> 
> 
> 
> Hi,
> 
> I sent an email to Gilles to introduce myself. I'll do it 
> again here :)
> 
> I'm about to include attal into the debian distribution. This 
> means I'm 
> spending some times to package it, and adapt it to the debian 
> standards 
> (putting images in /usr/share/attal for example). I'll keep 
> you informed of 
> the way I do it, and of the problems I meet.
> 
> Here is the list of packages generated from the sources 
> (sorted by sources):
> 
> attal-src-0.7.1.tar.bz2:
>   - attal-common
>   - attal-client
>   - attal-server
>   - attal-tools (scenario and theme builder)
>   - attal-ai
> de-0.7.1.tar.bz2:
>   - attal-locale-de
> fr-0.7.1.tar.bz2:
>   - attal-locale-fr
> ru-0.7.1.tar.bz2:
>   - attal-locale-ru
> theme-0.7.1.tar.bz2:
>   - attal-theme-medieval
>   - attal-theme-cyberpunk
> 
> I don't meet unsolveable problems with attal. I had some 
> difficulties with 
> your AttalStyle. You're subclassing QWindowsStyle into 
> libClient. This must 
> not be done because QWindowsStyle is not present at 
> compilation time. It is 
> loaded as a plugin later.
> 
> I'll have to take AttalStyle out of libClient and make it a 
> plugin, then I'll 
> load it in attal-client the usual way (dynamically). If you 
> want, I can give 
> you the patch for that.
> 
> Raphael
> 
> 
> 
> 
> 
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Attal-devel mailing list
> Att...@li...
> https://lists.sourceforge.net/lists/listinfo/attal-devel
> 
###########################################

This message has been scanned by F-Secure Anti-Virus for Microsoft Exchange.
For more information, connect to http://www.F-Secure.com/

Hi,

I sent an email to Gilles to introduce myself. I'll do it again here :)

I'm about to include attal into the debian distribution. This means I'm 
spending some times to package it, and adapt it to the debian standards 
(putting images in /usr/share/attal for example). I'll keep you informed of 
the way I do it, and of the problems I meet.

Here is the list of packages generated from the sources (sorted by sources):

attal-src-0.7.1.tar.bz2:
  - attal-common
  - attal-client
  - attal-server
  - attal-tools (scenario and theme builder)
  - attal-ai
de-0.7.1.tar.bz2:
  - attal-locale-de
fr-0.7.1.tar.bz2:
  - attal-locale-fr
ru-0.7.1.tar.bz2:
  - attal-locale-ru
theme-0.7.1.tar.bz2:
  - attal-theme-medieval
  - attal-theme-cyberpunk

I don't meet unsolveable problems with attal. I had some difficulties with 
your AttalStyle. You're subclassing QWindowsStyle into libClient. This must 
not be done because QWindowsStyle is not present at compilation time. It is 
loaded as a plugin later.

I'll have to take AttalStyle out of libClient and make it a plugin, then I'll 
load it in attal-client the usual way (dynamically). If you want, I can give 
you the patch for that.

Raphael

Well, the best is to write on this mailing-list but unfortunately few people
do :-(
So you can talk here.
(I'm listenning :) )

Pascal

> -----Message d'origine-----
> De : Raphael Goulais [mailto:ra...@ni...]
> Envoye : mardi 2 septembre 2003 17:12
> A : att...@li...
> Objet : [Attal-devel] Is attal-devel still alive ?
> 
> 
> 
> Hi :o)
> 
> Is there still someone on this list, or do we need to talk 
> with the Attal 
> developpers by private mail ?
> 
> Raphael
> 
> 
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Attal-devel mailing list
> Att...@li...
> https://lists.sourceforge.net/lists/listinfo/attal-devel
> 
###########################################

This message has been scanned by F-Secure Anti-Virus for Microsoft Exchange.
For more information, connect to http://www.F-Secure.com/

Hi :o)

Is there still someone on this list, or do we need to talk with the Attal 
developpers by private mail ?

Raphael