ccnet-devel Mailing List for CruiseControl.NET

Hi all

The conversion to svn of the patch is done. Many thanks go to
Gary Feldman with his testing hat for help with NMock ;-)

I've placed 2 new files on the JIRA site for this issue
http://jira.public.thoughtworks.org/browse/CCNET-158
 - CCNET158_svn.zip
     the patch in svn format
- CCNetListener.zip
    the NANT listener

For the moment the Nant listener uses file references, maybe
we have to include it in the main solution using project references.
Downside is that it will cause a reference to a certain version of Nant.

I would prefer to keep it as a 3rd party dll, because this functionality
does not belong to CCnet, but to Nant. Maybe a separate project on
the ccnet live site
http://ccnetlive.thoughtworks.com/ccnet
in the likes of NetReflector, MSBuild XmlLogger, ...


If there are any questions / remarks, let me know.

with kind regards

Hi

Thanks for the explanation, I'll try that approach and let you know.

with kind regards

On 8/29/06, Gary Feldman <sf_...@ma...> wrote:
> Ruben Willems wrote:
> > Hi
> >
> > The Integration Runner does a call to the Nant task,
> > requesting the deletion of the file.
> >
> > I would think that the Integration runner would do the high level items
> > - launch tasks
> > - check for modifications
> > but pass the actual work to lower classes.
> >
> >
> > It's the same with my patch (in my opinion)
> >
> No.  The IntegrationRunner runs the Project, and the Project runs the
> tasks.  The Project class doesn't deal with specific classes; it uses
> the ITask interface (which, by the way, is in the same namespace as
> IntegrationRunner) to run tasks.  You're not running the task, you're
> invoking a specific method on a task class.
>
> My suggestion is to make the method private and invoke it from the
> NAntTask.Run method.  If that doesn't work (since that would invoke it
> once per task, instead of once per integration), then you're probably
> best off letting the user worry about it, until such time as the
> artifact directory can support such items.
>
> Gary
>
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Ccnet-devel mailing list
> Ccn...@li...
> https://lists.sourceforge.net/lists/listinfo/ccnet-devel
>

Ruben Willems wrote:
> Hi
>
> The Integration Runner does a call to the Nant task,
> requesting the deletion of the file.
>
> I would think that the Integration runner would do the high level items
> - launch tasks
> - check for modifications
> but pass the actual work to lower classes.
>
>
> It's the same with my patch (in my opinion)
>   
No.  The IntegrationRunner runs the Project, and the Project runs the 
tasks.  The Project class doesn't deal with specific classes; it uses 
the ITask interface (which, by the way, is in the same namespace as 
IntegrationRunner) to run tasks.  You're not running the task, you're 
invoking a specific method on a task class.

My suggestion is to make the method private and invoke it from the 
NAntTask.Run method.  If that doesn't work (since that would invoke it 
once per task, instead of once per integration), then you're probably 
best off letting the user worry about it, until such time as the 
artifact directory can support such items.

Gary

Hi

The Integration Runner does a call to the Nant task,
requesting the deletion of the file.

I would think that the Integration runner would do the high level items
- launch tasks
- check for modifications
but pass the actual work to lower classes.


It's the same with my patch (in my opinion)
Nmock does not really complain about the call to the Nant-task,
but with the parameter passed to this function :
result.ProjectName

I'll have a look again at the patch
thanks anyway for your time for explaining NMock.


with kind regards


On 8/29/06, Gary Feldman <sf_...@ma...> wrote:
> Ruben Willems wrote:
> > Hi
> >
> > <quote>
> > The IntegrationRunner shouldn't know about the  mechanisms peculiar to
> > a specific type of task.
> > <quote>
> > My thoughts exactly, so how do I fix this?
> > I have no real experience with NMock.
> >
> At this point, the problem isn't with NMock, but with your fix.  The
> deletion of the NAnt log needs to be moved out of IntegrationRunner.  It
> might go into an appropriate place in the NAnt task.  If that can't be
> made to work, then another alternative is to generate unique file names
> and require the user to delete them some other way (unfortunate, but
> functional).
>
> At the brute force end in the test, if you had to add a method from some
> other class like this to a module, you'd need to add a brand new mock
> for it to the unit test.  Because the NAntTask class is so far removed
> from the IntegrationRunner, that's not easy to do in this case, but in
> other situations it would be the right strategy.  In general, you mock
> classes that are used by the class under test; in this case,
> IntegrationRunner is the class under test.
>
> Gary
> >
> > with kind regards
> >
> > On 8/28/06, Gary Feldman <sf_...@ma...> wrote:
> >
> >> Ruben Willems wrote:
> >>
> >>> ...
> >>> I've added
> >>> Tasks.NAntTask.DeleteCCNetNantListenFile(result.ProjectName);
> >>>
> >>> between
> >>>    result.MarkStartTime();
> >>> and
> >>>   result.Modifications = GetModifications(lastResult, result);
> >>>
> >>> I know I have to do a similar thing in the mocking,
> >>> but I am unsuccessful in this. Any help would be greatly appreciated.
> >>>
> >> Without actually looking at the code, and just putting on my testing
> >> hat, this is generally the wrong way to approach mocks.  You only need
> >> to mirror a change in a mock if you know that you've actually changed
> >> the way the mock is being called or the number of times it's being
> >> called.  Changing a mock to fix a test failure in unfamiliar code is
> >> always a suspicious thing to do.
> >>
> >> I don't think that's what you've done, and I'm guessing that the NAnt
> >> related task you've called is throwing an exception during the test.  A
> >> brute force approach at this point suggests mocking the
> >> DeleteCCNetNantListenFile method, but that doesn't feel right.  My gut
> >> feel, again without looking at the code,  is that this is the wrong
> >> place to be doing this.  The IntegrationRunner shouldn't know about the
> >> mechanisms peculiar to a specific type of task.
> >>
> >> Gary
> >>
> >>
> >>
> >> -------------------------------------------------------------------------
> >> Using Tomcat but need to do more? Need to support web services, security?
> >> Get stuff done quickly with pre-integrated technology to make your job easier
> >> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> >> _______________________________________________
> >> Ccnet-devel mailing list
> >> Ccn...@li...
> >> https://lists.sourceforge.net/lists/listinfo/ccnet-devel
> >>
> >>
> >
> > -------------------------------------------------------------------------
> > Using Tomcat but need to do more? Need to support web services, security?
> > Get stuff done quickly with pre-integrated technology to make your job easier
> > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> > _______________________________________________
> > Ccnet-devel mailing list
> > Ccn...@li...
> > https://lists.sourceforge.net/lists/listinfo/ccnet-devel
> >
> >
>
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Ccnet-devel mailing list
> Ccn...@li...
> https://lists.sourceforge.net/lists/listinfo/ccnet-devel
>

Ruben Willems wrote:
> Hi
>
> <quote>
> The IntegrationRunner shouldn't know about the  mechanisms peculiar to
> a specific type of task.
> <quote>
> My thoughts exactly, so how do I fix this?
> I have no real experience with NMock.
>   
At this point, the problem isn't with NMock, but with your fix.  The 
deletion of the NAnt log needs to be moved out of IntegrationRunner.  It 
might go into an appropriate place in the NAnt task.  If that can't be 
made to work, then another alternative is to generate unique file names 
and require the user to delete them some other way (unfortunate, but 
functional).

At the brute force end in the test, if you had to add a method from some 
other class like this to a module, you'd need to add a brand new mock 
for it to the unit test.  Because the NAntTask class is so far removed 
from the IntegrationRunner, that's not easy to do in this case, but in 
other situations it would be the right strategy.  In general, you mock 
classes that are used by the class under test; in this case, 
IntegrationRunner is the class under test.

Gary
>
> with kind regards
>
> On 8/28/06, Gary Feldman <sf_...@ma...> wrote:
>   
>> Ruben Willems wrote:
>>     
>>> ...
>>> I've added
>>> Tasks.NAntTask.DeleteCCNetNantListenFile(result.ProjectName);
>>>
>>> between
>>>    result.MarkStartTime();
>>> and
>>>   result.Modifications = GetModifications(lastResult, result);
>>>
>>> I know I have to do a similar thing in the mocking,
>>> but I am unsuccessful in this. Any help would be greatly appreciated.
>>>       
>> Without actually looking at the code, and just putting on my testing
>> hat, this is generally the wrong way to approach mocks.  You only need
>> to mirror a change in a mock if you know that you've actually changed
>> the way the mock is being called or the number of times it's being
>> called.  Changing a mock to fix a test failure in unfamiliar code is
>> always a suspicious thing to do.
>>
>> I don't think that's what you've done, and I'm guessing that the NAnt
>> related task you've called is throwing an exception during the test.  A
>> brute force approach at this point suggests mocking the
>> DeleteCCNetNantListenFile method, but that doesn't feel right.  My gut
>> feel, again without looking at the code,  is that this is the wrong
>> place to be doing this.  The IntegrationRunner shouldn't know about the
>> mechanisms peculiar to a specific type of task.
>>
>> Gary
>>
>>
>>
>> -------------------------------------------------------------------------
>> Using Tomcat but need to do more? Need to support web services, security?
>> Get stuff done quickly with pre-integrated technology to make your job easier
>> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
>> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>> _______________________________________________
>> Ccnet-devel mailing list
>> Ccn...@li...
>> https://lists.sourceforge.net/lists/listinfo/ccnet-devel
>>
>>     
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Ccnet-devel mailing list
> Ccn...@li...
> https://lists.sourceforge.net/lists/listinfo/ccnet-devel
>
>   

Hi

<quote>
The IntegrationRunner shouldn't know about the  mechanisms peculiar to
a specific type of task.
<quote>
My thoughts exactly, so how do I fix this?
I have no real experience with NMock.


with kind regards

On 8/28/06, Gary Feldman <sf_...@ma...> wrote:
> Ruben Willems wrote:
> > ...
> > I've added
> > Tasks.NAntTask.DeleteCCNetNantListenFile(result.ProjectName);
> >
> > between
> >    result.MarkStartTime();
> > and
> >   result.Modifications = GetModifications(lastResult, result);
> >
> > I know I have to do a similar thing in the mocking,
> > but I am unsuccessful in this. Any help would be greatly appreciated.
> Without actually looking at the code, and just putting on my testing
> hat, this is generally the wrong way to approach mocks.  You only need
> to mirror a change in a mock if you know that you've actually changed
> the way the mock is being called or the number of times it's being
> called.  Changing a mock to fix a test failure in unfamiliar code is
> always a suspicious thing to do.
>
> I don't think that's what you've done, and I'm guessing that the NAnt
> related task you've called is throwing an exception during the test.  A
> brute force approach at this point suggests mocking the
> DeleteCCNetNantListenFile method, but that doesn't feel right.  My gut
> feel, again without looking at the code,  is that this is the wrong
> place to be doing this.  The IntegrationRunner shouldn't know about the
> mechanisms peculiar to a specific type of task.
>
> Gary
>
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Ccnet-devel mailing list
> Ccn...@li...
> https://lists.sourceforge.net/lists/listinfo/ccnet-devel
>

Ruben Willems wrote:
> ...
> I've added
> Tasks.NAntTask.DeleteCCNetNantListenFile(result.ProjectName);
>
> between
>    result.MarkStartTime();
> and
>   result.Modifications = GetModifications(lastResult, result);
>
> I know I have to do a similar thing in the mocking,
> but I am unsuccessful in this. Any help would be greatly appreciated.
Without actually looking at the code, and just putting on my testing 
hat, this is generally the wrong way to approach mocks.  You only need 
to mirror a change in a mock if you know that you've actually changed 
the way the mock is being called or the number of times it's being 
called.  Changing a mock to fix a test failure in unfamiliar code is 
always a suspicious thing to do.

I don't think that's what you've done, and I'm guessing that the NAnt 
related task you've called is throwing an exception during the test.  A 
brute force approach at this point suggests mocking the 
DeleteCCNetNantListenFile method, but that doesn't feel right.  My gut 
feel, again without looking at the code,  is that this is the wrong 
place to be doing this.  The IntegrationRunner shouldn't know about the 
mechanisms peculiar to a specific type of task.

Gary

Hi all

Friday I took the latest svn build, and started to re-make the patch.
All the functionality is in this patch, but there is a small problem :
NMock ( I have often problems with NMock and CCNet patches :-(( )

I get the following error :

TestCase 'ThoughtWorks.CruiseControl.UnitTests.Core.IntegrationRunnerTest.ShouldNotRunBuildIfResultShouldNotBuild'
failed:
NMock.VerifyException :
	MockIIntegrationResult.ProjectName) called too many times

	expected:<0>
	 but was:<1>
	at NMock.Mock.Invoke(String methodName, Object[] args)
	at ProxyIIntegrationResult_3.get_ProjectName()
	c:\temp\ccnet\project\unittests\core\integrationrunnertest.cs(147,0):
at ThoughtWorks.CruiseControl.UnitTests.Core.IntegrationRunnerTest.SetupPreambleExpections()
	c:\temp\ccnet\project\unittests\core\integrationrunnertest.cs(70,0):
at ThoughtWorks.CruiseControl.UnitTests.Core.IntegrationRunnerTest.ShouldNotRunBuildIfResultShouldNotBuild()


My changes to the public IIntegrationResult
Integrate(IntegrationRequest request)

I've added
Tasks.NAntTask.DeleteCCNetNantListenFile(result.ProjectName);

between
    result.MarkStartTime();
and
   result.Modifications = GetModifications(lastResult, result);

I know I have to do a similar thing in the mocking,
but I am unsuccessful in this. Any help would be greatly appreciated.

with kind regards


On 8/26/06, Ruben Willems <rub...@gm...> wrote:
> Hi
>
> You read my path correctly,
> I will have a look at that file system watcher and see if I can get it to work.
>
> with kind regards
>
>
> On 8/25/06, Thomas Freudenberg <in...@th...> wrote:
> > MSBuild does support this. Either you can use the included File Logger
> > [1] or write your own one [2].
> >
> > However, I doubt it's a good idea to use files for interprocess
> > communication. Wouldn't it be more convenient to use remoting or some
> > other IPC mechanism?
> >
> > I threw a glance at your patch, and if I understand it correctly
> > you're polling the file? I suggest to use a FileSystemWatcher instead
> > to get notified automatically if the file was modified. [3]
> >
> > Regards,
> > Thomas
> >
> >
> > [1] http://msdn2.microsoft.com/en-us/library/ms171470.aspx
> > [2] http://msdn2.microsoft.com/en-us/library/ms171471.aspx
> > [3] http://msdn2.microsoft.com/system.io.filesystemwatcher
> >
> > On 8/25/06, Ruben Willems <rub...@gm...> wrote:
> > > Hi
> > >
> > > check
> > > http://nant.sourceforge.net/release/latest/help/fundamentals/listeners.html
> > > at the bottom of the page.
> > >
> > > I've made a new Nant listener,
> > > basically it listens to Nant events(standard Nant functionality)
> > > and writes these events with their data to an xml file.
> > >
> > > So whenever a certain event goes off in Nant, this file gets updated/rewritten.
> > > Every X seconds the dashboard/cctray visualize the contents of this file.
> > >
> > > The benefit is that it is standard NAnt functionality, one does not have to
> > > update their ccnet project to take advantage of this approach.
> > >
> > > Probably MSbuild has something similar, if you can subscribe to
> > > certain events of the MSuild engine, and reroute the information to a file,
> > > you will have the same functionality.
> > >
> > >
> > > with kind regards
> > >
> > >
> > >
> > >
> > >
> > > On 8/25/06, Thomas Freudenberg <in...@th...> wrote:
> > > > Hi Ruben,
> > > >
> > > > sounds interesting. Can you explain the details? How does the
> > > > communication work between NAnt and CCNet work?
> > > >
> > > > Maybe I can start developing a corresponding extension for MSBuild.
> > > >
> > > > Regards,
> > > > Thomas
> > > >
> > > >
> > > > Ruben Willems wrote:
> > > > > Hi all
> > > > >
> > > > > Can the patch for issue 158 be included in one of the next builds?
> > > > > It is scheduled for the 1.1 release, but did not made it into a
> > > > > nightly build yet.
> > > > >
> > > > > We have a large code base, and the compile and distribute takes some time,
> > > > > so it is handy to know how far the build is already.
> > > > >
> > > > > If there are issues with the patch, please let me know.
> > > > >
> > > > > with kind regards
> > > > > Ruben Willems
> > > > >
> >
> > -------------------------------------------------------------------------
> > Using Tomcat but need to do more? Need to support web services, security?
> > Get stuff done quickly with pre-integrated technology to make your job easier
> > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> > _______________________________________________
> > Ccnet-devel mailing list
> > Ccn...@li...
> > https://lists.sourceforge.net/lists/listinfo/ccnet-devel
> >
>

Hi all,

I was trying to setup the SMTP mailing publisher again for CC.net and
of course ran into a couple of problems. I've noticed this before
(http://jira.public.thoughtworks.org/browse/CCNET-401) and the fix I
applied for my own purposes that time was to simple use the
DotNetOpenMail library. It's mentioned in the thread that the .net 2.0
net.mail client should be used, it's true that this can be done, but
as they mention in these to places:

http://forums.microsoft.com/MSDN/ShowPost.aspx?PostID=112971&SiteID=1
http://support.microsoft.com/?kbid=913616

that solution have problems of it's own (e.g. virus
scanners/firewalls). The DotNetOpenMail library is still working
pretty well, I've got it sending emails now for quite a while. Was the
dotnetopenmail solution rejected in favour of waiting for MS to patch
the .net runtime for the net.mail client? Or should we perhaps just
implement the email thing in terms of dotnetopenmail? Or just have the
broken version that's currently in?

Cheers,
Jim Tilander

-- 
Beware of architect astronauts.

Hi

You read my path correctly,
I will have a look at that file system watcher and see if I can get it to work.

with kind regards


On 8/25/06, Thomas Freudenberg <in...@th...> wrote:
> MSBuild does support this. Either you can use the included File Logger
> [1] or write your own one [2].
>
> However, I doubt it's a good idea to use files for interprocess
> communication. Wouldn't it be more convenient to use remoting or some
> other IPC mechanism?
>
> I threw a glance at your patch, and if I understand it correctly
> you're polling the file? I suggest to use a FileSystemWatcher instead
> to get notified automatically if the file was modified. [3]
>
> Regards,
> Thomas
>
>
> [1] http://msdn2.microsoft.com/en-us/library/ms171470.aspx
> [2] http://msdn2.microsoft.com/en-us/library/ms171471.aspx
> [3] http://msdn2.microsoft.com/system.io.filesystemwatcher
>
> On 8/25/06, Ruben Willems <rub...@gm...> wrote:
> > Hi
> >
> > check
> > http://nant.sourceforge.net/release/latest/help/fundamentals/listeners.html
> > at the bottom of the page.
> >
> > I've made a new Nant listener,
> > basically it listens to Nant events(standard Nant functionality)
> > and writes these events with their data to an xml file.
> >
> > So whenever a certain event goes off in Nant, this file gets updated/rewritten.
> > Every X seconds the dashboard/cctray visualize the contents of this file.
> >
> > The benefit is that it is standard NAnt functionality, one does not have to
> > update their ccnet project to take advantage of this approach.
> >
> > Probably MSbuild has something similar, if you can subscribe to
> > certain events of the MSuild engine, and reroute the information to a file,
> > you will have the same functionality.
> >
> >
> > with kind regards
> >
> >
> >
> >
> >
> > On 8/25/06, Thomas Freudenberg <in...@th...> wrote:
> > > Hi Ruben,
> > >
> > > sounds interesting. Can you explain the details? How does the
> > > communication work between NAnt and CCNet work?
> > >
> > > Maybe I can start developing a corresponding extension for MSBuild.
> > >
> > > Regards,
> > > Thomas
> > >
> > >
> > > Ruben Willems wrote:
> > > > Hi all
> > > >
> > > > Can the patch for issue 158 be included in one of the next builds?
> > > > It is scheduled for the 1.1 release, but did not made it into a
> > > > nightly build yet.
> > > >
> > > > We have a large code base, and the compile and distribute takes some time,
> > > > so it is handy to know how far the build is already.
> > > >
> > > > If there are issues with the patch, please let me know.
> > > >
> > > > with kind regards
> > > > Ruben Willems
> > > >
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Ccnet-devel mailing list
> Ccn...@li...
> https://lists.sourceforge.net/lists/listinfo/ccnet-devel
>

MSBuild does support this. Either you can use the included File Logger
[1] or write your own one [2].

However, I doubt it's a good idea to use files for interprocess
communication. Wouldn't it be more convenient to use remoting or some
other IPC mechanism?

I threw a glance at your patch, and if I understand it correctly
you're polling the file? I suggest to use a FileSystemWatcher instead
to get notified automatically if the file was modified. [3]

Regards,
Thomas


[1] http://msdn2.microsoft.com/en-us/library/ms171470.aspx
[2] http://msdn2.microsoft.com/en-us/library/ms171471.aspx
[3] http://msdn2.microsoft.com/system.io.filesystemwatcher

On 8/25/06, Ruben Willems <rub...@gm...> wrote:
> Hi
>
> check
> http://nant.sourceforge.net/release/latest/help/fundamentals/listeners.html
> at the bottom of the page.
>
> I've made a new Nant listener,
> basically it listens to Nant events(standard Nant functionality)
> and writes these events with their data to an xml file.
>
> So whenever a certain event goes off in Nant, this file gets updated/rewritten.
> Every X seconds the dashboard/cctray visualize the contents of this file.
>
> The benefit is that it is standard NAnt functionality, one does not have to
> update their ccnet project to take advantage of this approach.
>
> Probably MSbuild has something similar, if you can subscribe to
> certain events of the MSuild engine, and reroute the information to a file,
> you will have the same functionality.
>
>
> with kind regards
>
>
>
>
>
> On 8/25/06, Thomas Freudenberg <in...@th...> wrote:
> > Hi Ruben,
> >
> > sounds interesting. Can you explain the details? How does the
> > communication work between NAnt and CCNet work?
> >
> > Maybe I can start developing a corresponding extension for MSBuild.
> >
> > Regards,
> > Thomas
> >
> >
> > Ruben Willems wrote:
> > > Hi all
> > >
> > > Can the patch for issue 158 be included in one of the next builds?
> > > It is scheduled for the 1.1 release, but did not made it into a
> > > nightly build yet.
> > >
> > > We have a large code base, and the compile and distribute takes some time,
> > > so it is handy to know how far the build is already.
> > >
> > > If there are issues with the patch, please let me know.
> > >
> > > with kind regards
> > > Ruben Willems
> > >

Hi

check
http://nant.sourceforge.net/release/latest/help/fundamentals/listeners.html
at the bottom of the page.

I've made a new Nant listener,
basically it listens to Nant events(standard Nant functionality)
and writes these events with their data to an xml file.

So whenever a certain event goes off in Nant, this file gets updated/rewritten.
Every X seconds the dashboard/cctray visualize the contents of this file.

The benefit is that it is standard NAnt functionality, one does not have to
update their ccnet project to take advantage of this approach.

Probably MSbuild has something similar, if you can subscribe to
certain events of the MSuild engine, and reroute the information to a file,
you will have the same functionality.


with kind regards





On 8/25/06, Thomas Freudenberg <in...@th...> wrote:
> Hi Ruben,
>
> sounds interesting. Can you explain the details? How does the
> communication work between NAnt and CCNet work?
>
> Maybe I can start developing a corresponding extension for MSBuild.
>
> Regards,
> Thomas
>
>
> Ruben Willems wrote:
> > Hi all
> >
> > Can the patch for issue 158 be included in one of the next builds?
> > It is scheduled for the 1.1 release, but did not made it into a
> > nightly build yet.
> >
> > We have a large code base, and the compile and distribute takes some time,
> > so it is handy to know how far the build is already.
> >
> > If there are issues with the patch, please let me know.
> >
> > with kind regards
> > Ruben Willems
> >
> > -------------------------------------------------------------------------
> > Using Tomcat but need to do more? Need to support web services, security?
> > Get stuff done quickly with pre-integrated technology to make your job easier
> > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Ccnet-devel mailing list
> Ccn...@li...
> https://lists.sourceforge.net/lists/listinfo/ccnet-devel
>

Hi Ruben,

sounds interesting. Can you explain the details? How does the
communication work between NAnt and CCNet work?

Maybe I can start developing a corresponding extension for MSBuild.

Regards,
Thomas


Ruben Willems wrote:
> Hi all
>
> Can the patch for issue 158 be included in one of the next builds?
> It is scheduled for the 1.1 release, but did not made it into a
> nightly build yet.
>
> We have a large code base, and the compile and distribute takes some time,
> so it is handy to know how far the build is already.
>
> If there are issues with the patch, please let me know.
>
> with kind regards
> Ruben Willems
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Hi Ruben,
=20
Just to clarify, I didn't read the diff all the way through, so I'm not =
sure if the unit tests were there. My apologies about the conversion, I =
wasn't on the project at the time, but I realize this is a big =
inconvenience for you. Hopefully it won't take too long to convert.
=20
Thanks,
=20
-Dan

________________________________

From: ccn...@li... on behalf of Ruben =
Willems
Sent: Fri 8/25/2006 1:32 AM
To: ccn...@li...
Subject: Re: [Ccnet-devel] CCNET-158



Hi

I'll try to find some time to convert the patch to subversion,
I thought it had unit tests, but will check again.

thanks for the prompt reply.


with kind regards

On 8/25/06, Piessens, Daniel <Dan...@re...> wrote:
> Hi Ruben,
>
> The code seems to look good, but it was difff'd against a CVS =
respostory
> that we no longer have. If you could check out the subversion trunk,
> move in your files and run and update to ensure there are no conflicts
> and submit the patch, I'd be happy to look at it. As Owen reminded me
> the other week though, please ensure that you have unit tests for you
> code and it follows the coding standards.
>
> -Dan Piessens
>
> -----Original Message-----
> From: ccn...@li...
> [mailto:ccn...@li...] On Behalf Of Ruben
> Willems
> Sent: Thursday, August 24, 2006 3:51 AM
> To: ccn...@li...
> Subject: [Ccnet-devel] CCNET-158
>
> Hi all
>
> Can the patch for issue 158 be included in one of the next builds?
> It is scheduled for the 1.1 release, but did not made it into a =
nightly
> build yet.
>
> We have a large code base, and the compile and distribute takes some
> time, so it is handy to know how far the build is already.
>
> If there are issues with the patch, please let me know.
>
> with kind regards
> Ruben Willems
>
> =
------------------------------------------------------------------------
> -
> Using Tomcat but need to do more? Need to support web services,
> security?
> Get stuff done quickly with pre-integrated technology to make your job
> easier Download IBM WebSphere Application Server v.1.0.1 based on =
Apache
> Geronimo
> =
http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D=
121642
> _______________________________________________
> Ccnet-devel mailing list
> Ccn...@li...
> https://lists.sourceforge.net/lists/listinfo/ccnet-devel
>
> =
-------------------------------------------------------------------------=

> Using Tomcat but need to do more? Need to support web services, =
security?
> Get stuff done quickly with pre-integrated technology to make your job =
easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache =
Geronimo
> =
http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D=
121642
> _______________________________________________
> Ccnet-devel mailing list
> Ccn...@li...
> https://lists.sourceforge.net/lists/listinfo/ccnet-devel
>

-------------------------------------------------------------------------=

Using Tomcat but need to do more? Need to support web services, =
security?
Get stuff done quickly with pre-integrated technology to make your job =
easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache =
Geronimo
http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D=
121642
_______________________________________________
Ccnet-devel mailing list
Ccn...@li...
https://lists.sourceforge.net/lists/listinfo/ccnet-devel

Hi

I'll try to find some time to convert the patch to subversion,
I thought it had unit tests, but will check again.

thanks for the prompt reply.


with kind regards

On 8/25/06, Piessens, Daniel <Dan...@re...> wrote:
> Hi Ruben,
>
> The code seems to look good, but it was difff'd against a CVS respostory
> that we no longer have. If you could check out the subversion trunk,
> move in your files and run and update to ensure there are no conflicts
> and submit the patch, I'd be happy to look at it. As Owen reminded me
> the other week though, please ensure that you have unit tests for you
> code and it follows the coding standards.
>
> -Dan Piessens
>
> -----Original Message-----
> From: ccn...@li...
> [mailto:ccn...@li...] On Behalf Of Ruben
> Willems
> Sent: Thursday, August 24, 2006 3:51 AM
> To: ccn...@li...
> Subject: [Ccnet-devel] CCNET-158
>
> Hi all
>
> Can the patch for issue 158 be included in one of the next builds?
> It is scheduled for the 1.1 release, but did not made it into a nightly
> build yet.
>
> We have a large code base, and the compile and distribute takes some
> time, so it is handy to know how far the build is already.
>
> If there are issues with the patch, please let me know.
>
> with kind regards
> Ruben Willems
>
> ------------------------------------------------------------------------
> -
> Using Tomcat but need to do more? Need to support web services,
> security?
> Get stuff done quickly with pre-integrated technology to make your job
> easier Download IBM WebSphere Application Server v.1.0.1 based on Apache
> Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Ccnet-devel mailing list
> Ccn...@li...
> https://lists.sourceforge.net/lists/listinfo/ccnet-devel
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Ccnet-devel mailing list
> Ccn...@li...
> https://lists.sourceforge.net/lists/listinfo/ccnet-devel
>

Hi Ruben,
=20
The code seems to look good, but it was difff'd against a CVS respostory
that we no longer have. If you could check out the subversion trunk,
move in your files and run and update to ensure there are no conflicts
and submit the patch, I'd be happy to look at it. As Owen reminded me
the other week though, please ensure that you have unit tests for you
code and it follows the coding standards.=20
=20
-Dan Piessens=20

-----Original Message-----
From: ccn...@li...
[mailto:ccn...@li...] On Behalf Of Ruben
Willems
Sent: Thursday, August 24, 2006 3:51 AM
To: ccn...@li...
Subject: [Ccnet-devel] CCNET-158

Hi all

Can the patch for issue 158 be included in one of the next builds?
It is scheduled for the 1.1 release, but did not made it into a nightly
build yet.

We have a large code base, and the compile and distribute takes some
time, so it is handy to know how far the build is already.

If there are issues with the patch, please let me know.

with kind regards
Ruben Willems

------------------------------------------------------------------------
-
Using Tomcat but need to do more? Need to support web services,
security?
Get stuff done quickly with pre-integrated technology to make your job
easier Download IBM WebSphere Application Server v.1.0.1 based on Apache
Geronimo
http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D=
121642
_______________________________________________
Ccnet-devel mailing list
Ccn...@li...
https://lists.sourceforge.net/lists/listinfo/ccnet-devel

Hi all

Can the patch for issue 158 be included in one of the next builds?
It is scheduled for the 1.1 release, but did not made it into a
nightly build yet.

We have a large code base, and the compile and distribute takes some time,
so it is handy to know how far the build is already.

If there are issues with the patch, please let me know.

with kind regards
Ruben Willems

Hi all,

Martin and I discussed this further at lunch, and we're not sure what 
the behavior should be...

The tests are hard-coded to look for slash-separated strings, so we took 
that to be the truth, and adjusted the code accordingly.

However, I'm not sure if Synergy or PVCS have locale-dependent tools, so 
that the separators are in fact localized for them too?

In that case, I guess the tests should be fixed to parse 
locale-invariant date strings, and compare to the expected dates 
instead... Or is there a better solution?

Cheers,
- Kim

Martin Mazur wrote:
> Hi,
> 
> I found that the code used in Pvcs.cs to get an invariant date time
> string does not actually work. The reason for this is because '/' and
> ':' in format strings are replaced by the default separator for the
> current culture unless an IFormatProvider is passed to the ToString 
> method. This caused the VerifyDateParser test to fail on a system using 
> swedish locale ('/' is replaced by '-').
> 
> I found another similar issue in SynergyCommandBuilder.cs.
> 
> The submitted patch (pair programmed with Kim Gräsman) 
> should solve these issues.

Recently added JSUnit tests (test runner has JUnit style xml output) along
with C# tests into our build and wanted to get that output into the
CruiseControl.NET Build Report.
 
After a little digging around, found that back in v.0.8 in CCNET-218
"Support JUnit output in unit test report" the unittests.xsl was modified to
be able to support some JUnit results processing on the web dashboard Build
Report page. We were encouraged that there was already some support for
JUnit results processing.
 
However, it turns out the reporting only works if JUnit results are present
and no NUnit results are present.
 
Made patch to fix this and submitted it via a new issue CCNET-734 "Support
JUnit output in unit test report on main build report page when both JUnit
and NUnit results are present". Patch updates unittests.xsl to support
combining JUnit and NUnit results togehter as per the spirit of the original
CCNET-218 submission.
 
Hopefully this patch can be incorporated into the main product. Let me know
if there is anything I can do to facilitate getting this fix in.
 
Thanks,
Michael

Hi,

The CreatePcliContentsForGet test in PvcsTest.cs seams to fail in NUnit 
2.2.4. I suspect that this is because NUnit sets the thread name to 
TestRunnerThread, and the property cannot be changed.

The submitted patch (pair programmed with Kim Gräsman <ki...@mv...>) 
solves this issue. Allthough it may cause the test to stop working with 
older versions of NUnit.

//M

Hi,

I found that the code used in Pvcs.cs to get an invariant date time
string does not actually work. The reason for this is because '/' and
':' in format strings are replaced by the default separator for the
current culture unless an IFormatProvider is passed to the ToString 
method. This caused the VerifyDateParser test to fail on a system using 
swedish locale ('/' is replaced by '-').

I found another similar issue in SynergyCommandBuilder.cs.

The submitted patch (pair programmed with Kim Gräsman <ki...@mv...>) 
should solve these issues.

//M

I searched the list and found next to nothing on what the class
IntegrationRequest is for.  It seems to bypass ForceBuild.  Is this a
partially implemented feature?

-- 
Jay Flowers
----------------------------------------------------------------------
http://jayflowers.com
---------------------------------------------------------------------

Hi Jay,
=20
If you would like to create a Jira issue for this =
http://confluence.public.thoughtworks.org/display/CCNET/Issues, and then =
create a patch file for subversion and attach it to this issue. One of =
the project moderators will review it and if it meets coding standards =
then we will merge it. One thing to remember is that the project is unit =
test driven so if you create new functionality, there needs to be unit =
tests to ensure integration. Also you may want to run the current unit =
tests (if you have the code just run b.bat in the root of the project) =
to make sure all current tests pass.=20
=20
-Dan Piessens

________________________________

From: ccn...@li... on behalf of Jay Flowers
Sent: Tue 8/22/2006 2:04 PM
To: ccn...@li...
Subject: Re: [Ccnet-devel] Force Filters


So I have a cut of this done.  I had to make modifications to cctraylib, =
core, remote, and dashboard.  The projectForceFilter is the same as the =
projectTriggerFilter.  The userForceFilter can work with usernames and =
or group membership.  I wrote the actual filters as plugins in a =
different assembly.  I made these changes against the 1.0 release scr =
zip.  The project I made these changes for is using 1.0.  I would like =
to get these changes into the trunk.  How can I get these changes into =
the trunk?

<forceFilters>
  <projectForceFilter>=20
    <projectFilters>
      <projectFilter =
serverUri=3D"tcp://localhost:21247/CruiseManager.rem" =
project=3D"experimental2">
        <exclusionFilters>
          <activities>=20
            <activity>Building</activity>
            <activity>CheckingModifications</activity>
          </activities>
        </exclusionFilters>
      </projectFilter>=20
    </projectFilters>
  </projectForceFilter>
  <userForceFilter domainName=3D"chcsii" userName=3D"user" =
password=3D"password">
    <includedUsers>
      <includedUser>jflowers</includedUser>=20
    </includedUsers>
  </userForceFilter>
</forceFilters>



On 8/18/06, Jay Flowers < jay...@gm... =
<mailto:jay...@gm...> > wrote:=20

	Hey,
	I would like to add the ability to control if a build can be forced.  =
For instance it would be nice to do something similar to the Project =
Trigger Filter disscussed in a recent post.  I would also like to allow =
this capatility to control who can force a build.  Clearly this would =
effect the ForceBuild method on both ICruiseServer and =
IProjectIntegrator as well as adding a new property to ProjectBase that =
would hold ForceFilters.  I was suprised to see a ProjectBase and find a =
Workflow class.  I don't know what workflow is for and how a force =
filter would effect it.  How the cashboard and cctray will be effect I =
am not sold on yet.  What do you think?=20
=09
	Thanks,
=09
=09
	--=20
	Jay Flowers
	----------------------------------------------------------------------
	http://jayflowers.com
	---------------------------------------------------------------------=20




--=20
Jay Flowers
----------------------------------------------------------------------
http://jayflowers.com
---------------------------------------------------------------------=20

So I have a cut of this done.  I had to make modifications to cctraylib,
core, remote, and dashboard.  The projectForceFilter is the same as the
projectTriggerFilter.  The userForceFilter can work with usernames and or
group membership.  I wrote the actual filters as plugins in a different
assembly.  I made these changes against the 1.0 release scr zip.  The
project I made these changes for is using 1.0.  I would like to get these
changes into the trunk.  How can I get these changes into the trunk?

<forceFilters>
  <projectForceFilter>
    <projectFilters>
      <projectFilter serverUri="tcp://localhost:21247/CruiseManager.rem"
project="experimental2">
        <exclusionFilters>
          <activities>
            <activity>Building</activity>
            <activity>CheckingModifications</activity>
          </activities>
        </exclusionFilters>
      </projectFilter>
    </projectFilters>
  </projectForceFilter>
  <userForceFilter domainName="chcsii" userName="user" password="password">
    <includedUsers>
      <includedUser>jflowers</includedUser>
    </includedUsers>
  </userForceFilter>
</forceFilters>


On 8/18/06, Jay Flowers <jay...@gm...> wrote:
>
> Hey,
> I would like to add the ability to control if a build can be forced.  For
> instance it would be nice to do something similar to the Project Trigger
> Filter disscussed in a recent post.  I would also like to allow this
> capatility to control who can force a build.  Clearly this would effect the
> ForceBuild method on both ICruiseServer and IProjectIntegrator as well as
> adding a new property to ProjectBase that would hold ForceFilters.  I was
> suprised to see a ProjectBase and find a Workflow class.  I don't know what
> workflow is for and how a force filter would effect it.  How the cashboard
> and cctray will be effect I am not sold on yet.  What do you think?
>
> Thanks,
>
> --
> Jay Flowers
> ----------------------------------------------------------------------
> http://jayflowers.com
> ---------------------------------------------------------------------
>



-- 
Jay Flowers
----------------------------------------------------------------------
http://jayflowers.com
---------------------------------------------------------------------

I found the cause of this.  It is happening because a plugin that is used in
the project config is not being loaded into the app domain of the
dashboard.  What mechanizim loads plugins into ccnet server?  I would like
to reuse that.

On 8/21/06, Jay Flowers <jay...@gm...> wrote:
>
> I am getting the exception: "ExpandableObjectConverter cannot convert from
> System.String." when I try to deserialize the string returned from
> ICruiseManager.GetProject(projectName).  Was this fully implemented?  If
> so what can cause this?  Here is the code recieving the exception.
>
> private readonly IProjectSerializer projectSerializer = new
> NetReflectorProjectSerializer();
>
> private IProject GetProject(ICruiseManager manager, string projectName)
> {
>     string serializedProject = manager.GetProject (projectName);
>     return this.projectSerializer.Deserialize(serializedProject);
> }
>
> Exception Message
>
> ExpandableObjectConverter cannot convert from System.String.
> Exception Full Details
>
> System.NotSupportedException: ExpandableObjectConverter cannot convert
> from System.String. at
> System.ComponentModel.TypeConverter.GetConvertFromException(Object value)
> at System.ComponentModel.TypeConverter.ConvertFrom(ITypeDescriptorContext
> context, CultureInfo culture, Object value) at
> System.ComponentModel.TypeConverter.ConvertFrom(Object value) at
> Exortech.NetReflector.XmlArraySerialiser.Read(XmlNode node, Type
> instanceType, NetReflectorTypeTable table) at
> Exortech.NetReflector.XmlMemberSerialiser.Read(XmlNode node,
> NetReflectorTypeTable table) at
> Exortech.NetReflector.XmlTypeSerialiser.ReadMembers(XmlNode node, Object
> instance, NetReflectorTypeTable table) at
> Exortech.NetReflector.XmlTypeSerialiser.Read(XmlNode node,
> NetReflectorTypeTable table) at
> Exortech.NetReflector.NetReflectorReader.Read(XmlNode node) at
> Exortech.NetReflector.NetReflectorReader.Read(XmlReader reader) at
> Exortech.NetReflector.NetReflectorReader.Read(TextReader reader) at
> Exortech.NetReflector.NetReflector.Read(String xml) at
> ThoughtWorks.CruiseControl.Core.NetReflectorProjectSerializer.Deserialize(String
> serializedProject) at
> ThoughtWorks.CruiseControl.WebDashboard.ServerConnection.ServerAggregatingCruiseManagerWrapper.GetProject(ICruiseManager
> manager, String projectName) at
> ThoughtWorks.CruiseControl.WebDashboard.ServerConnection.ServerAggregatingCruiseManagerWrapper.ForceBuild(IProjectSpecifier
> projectSpecifier) at
> ThoughtWorks.CruiseControl.WebDashboard.Dashboard.VelocityProjectGridAction.ForceBuildIfNecessary(IRequest
> request) at
> ThoughtWorks.CruiseControl.WebDashboard.Dashboard.VelocityProjectGridAction.Execute(String
> actionName, IRequest request) at
> ThoughtWorks.CruiseControl.WebDashboard.Plugins.FarmReport.FarmReportFarmPlugin.Execute(ICruiseRequest
> request) at
> ThoughtWorks.CruiseControl.WebDashboard.MVC.Cruise.CruiseActionProxyAction.Execute(IRequest
> request) at
> ThoughtWorks.CruiseControl.WebDashboard.MVC.Cruise.ExceptionCatchingActionProxy.Execute(IRequest
> request)
>
>
> --
> Jay Flowers
> ----------------------------------------------------------------------
> http://jayflowers.com
> ---------------------------------------------------------------------
>



-- 
Jay Flowers
----------------------------------------------------------------------
http://jayflowers.com
---------------------------------------------------------------------