astpp-tracker Mailing List for ASTPP - Open Source Voip Billing

Feature Requests item #1824453, was opened at 2007-11-01 22:06
Message generated for change (Comment added) made by darrenkw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=994549&aid=1824453&group_id=205663

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Priority: 5
Private: No
Submitted By: Mirza Sahib (mirzasahib)
Assigned to: Nobody/Anonymous (nobody)
Summary: Code Review Modularization

Initial Comment:
I'm putting all general code review, modularizations, templates etc thoughts here ...

a) all variables used need to be reviewed
b) duplicate code needs to be sub{}bed
c) start migrating stuff to ASTPP.pm
d) move all HTML out of cgi to HTML::Template
e) remove duplicate set var, exec set
f) improve verbose logging, debugging

----------------------------------------------------------------------

>Comment By: Aleph Communications (darrenkw)
Date: 2011-01-23 13:45

Message:
Nobody has volunteered to do this.  I'm working on moving code to perl
modules but that's not happening quickly.

----------------------------------------------------------------------

Comment By: Aleph Communications (darrenkw)
Date: 2008-09-01 23:31

Message:
Logged In: YES 
user_id=1227065
Originator: NO

Much of this is great but it's WAY too much work for me to attempt by
myself.

----------------------------------------------------------------------

Comment By: Mirza Sahib (mirzasahib)
Date: 2007-11-01 22:22

Message:
Logged In: YES 
user_id=1893410
Originator: YES

g) move from clams to 4 precision decimal
h) improve interface usability, help screens etc

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=994549&aid=1824453&group_id=205663

Bugs item #1824470, was opened at 2007-11-01 23:20
Message generated for change (Comment added) made by darrenkw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=994546&aid=1824470&group_id=205663

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Mirza Sahib (mirzasahib)
Assigned to: Nobody/Anonymous (nobody)
Summary: callindcardcdrs callstart is 0000

Initial Comment:
| 1099 | 41043723423428 | "anonymous" <0>                   | 001923400630   | CANCEL         | 0000-00-00 00:00:00 |       0 |     0.000000 | 0.000000 |      0 |          |       |
| 1100 | 392523423425725 | "07903619707" <07903619707>       | 00923234326067* | CHANUNAVAIL    | 0000-00-00 00:00:00 |       0 |     0.000000 | 0.000000 |      0 |          |       |
| 1101 | 39252342345725 | "07903619707" <07903619707>       | 0092323424326067  | ANSWER         | 0000-00-00 00:00:00 |     698 |  5400.000000 | 0.000000 |      0 |          | 

all cdrs have this 0000-00-00 00:00:00

i checked &prettytimestamp that seems ok
will take some debugging output to isolate where $callstart is getting nulled

----------------------------------------------------------------------

>Comment By: Aleph Communications (darrenkw)
Date: 2011-01-23 13:43

Message:
This was fixed some time ago

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=994546&aid=1824470&group_id=205663