Fix flaky test: MergeRequestReferenceFilter URL reference for a commit
What does this MR do and why?
Fix flaky test: MergeRequestReferenceFilter URL reference for a commit
The test was failing intermittently because the Banzai filter's project context didn't match the merge request's owning project.
The test creates two projects:
-
project(line 8) - default filter context -
mr_project(line 269) - owns the MR being tested
When reference_filter is called without explicit project parameter,
it uses project from line 8. The filter's reference cache can't
find the MR (wrong project scope), returning the URL unchanged.
Fix: Pass mr_project as the project context to reference_filter.
Closes https://gitlab.com/gitlab-org/quality/test-failure-issues/-/issues/2963
References
Screenshots or screen recordings
| Before | After |
|---|---|
How to set up and validate locally
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.