From cf64d34a0e11a20fc5b7b8e1e2d7e37f3bd90a3e Mon Sep 17 00:00:00 2001 From: Marc Shaw Date: Wed, 17 Dec 2025 18:38:43 +0100 Subject: [PATCH] Fix flaky test: MergeRequestReferenceFilter URL reference for a commit The test was failing intermittently because the Banzai filter's project context didn't match the merge request's owning project. The test creates two projects: - `project` (line 8) - default filter context - `mr_project` (line 269) - owns the MR being tested When reference_filter is called without explicit project parameter, it uses `project` from line 8. The filter's reference cache can't find the MR (wrong project scope), returning the URL unchanged. Fix: Pass mr_project as the project context to reference_filter. Closes https://gitlab.com/gitlab-org/quality/test-failure-issues/-/issues/2963 --- .../filter/references/merge_request_reference_filter_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/lib/banzai/filter/references/merge_request_reference_filter_spec.rb b/spec/lib/banzai/filter/references/merge_request_reference_filter_spec.rb index 4b8035220ad786..cefd3ef33109a4 100644 --- a/spec/lib/banzai/filter/references/merge_request_reference_filter_spec.rb +++ b/spec/lib/banzai/filter/references/merge_request_reference_filter_spec.rb @@ -277,7 +277,7 @@ end it 'has valid text' do - doc = reference_filter("See #{reference}") + doc = reference_filter("See #{reference}", project: mr_project) expect(doc.text).to eq("See #{mr.to_reference(full: true)} (#{commit.short_id})") end -- GitLab