Remove workspaces feature flag controller
Issue: Remove workspaces feature flag controller (#534818 - closed)
What does this MR do and why?
This MR removes the workspaces feature flag controller as part of tech-debt cleanup because it is not being used anymore and it violates the new rubocop rule introduces here Add Cop against dynamic FF keys (!186357 - merged) which specifies that feature flag calls should static and must include a literal symbol.
Based on this review comment i believe it was scheduled for cleanup
The workspaces feature flag controller was introduced here: Fix workspaces frontend auth feature flag (!152454 - merged) as a bug fix.
Related feature flag cleanup MR: [Feature flag] Cleanup `remote_development_name... (#474784 - closed)
References
- Add Cop against dynamic FF keys (!186357 - merged)
- Fix workspaces frontend auth feature flag (#460999 - closed)
- Fix workspaces frontend auth feature flag (!152454 - merged)
- [Feature flag] Cleanup `remote_development_name... (#474784 - closed)
- Add ignore for rubocop Gitlab/FeatureFlagKeyDyn... (!187290 - closed)
- https://gitlab.com/gitlab-org/gitlab/-/issues/522906+
Screenshots or screen recordings
There are no UI changes
| Before | After |
|---|---|
How to set up and validate locally
- Run
bin/rspec scripts/remote_development/run-smoke-test-suite.sh
It should pass without any failing tests
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.