FY22-Q4 Perceived performance audit - Create:Code Review - Propose changes

Repeat the audit done in #1608 (closed) to identify opportunities to improve the perceived performance of the MRs experience, but now in the following JTBD:

When product improvements are identified, I want to propose changes that address them, so that I can help build a better product.

• Personas: Sasha (Software Developer)
• Recommendations: Linked as related issues.

Scenarios

• 📄 Testing guide
• Inspired by the scenarios used in CM Scorecard - Create:Source Code:Code Review FY21-Q2 (testing guide for JTBD 1 and 2 of that study).

Identified opportunities

New branch

1. Add loading state to “Create branch” button
   

Single-file editor

1. Add loading state to “Commit changes” button
   

Web IDE

1. Consolidate the two main loading states
   CleanShot_20211213104203

Compare branches

1. Background load the branch dropdown list
   
2. Add loading state to “Compare changes and continue” button
   

Merge request form

1. Show only one “draft” help text when page is loading
   
2. Lazy load the commits list
3. Background load the assignees and reviewers dropdowns list
   
4. Save the assignees and reviewers dropdowns search results to avoid re-requests
   CleanShot_20211214144508
5. Add loading state to “Create merge request” and “Save changes” buttons
   

Comment

1. Save the @-mention autocomplete results to avoid re-requests
   CleanShot_20211214144950

Merge request detail

1. Add loading state to “Mark as draft/ready” button
   

Not related to perceived performance

1. In the repository, the “Go to parent directory” .. link needs a tooltip
   
2. In the commit summary, the “Show commit message body” … button needs a tooltip and aria-label
   
3. In the single-file editor, the “Write” and “Preview” tabs have a double bottom border on hover
   
4. Toggling MR draft state sometimes triggers error or MR dependencies block
   CleanShot_20211214145747 CleanShot_20211214145540
5. Using draft quick action should show toast instead of alert