FY22-Q2 Perceived performance audit - Create:Code Review - Review changes
The focus of this audit is to identify opportunities to improve the perceived performance of the MRs experience, specifically in the following JTBD:
When my teammates propose changes, I want to review them before they are accepted, so that I can help increase the quality of changes, minimize the risk of defects, minimize the risk of out-of-scope changes, and grow the team’s expertise.
- Personas: Sasha (Software Developer)
- Recommendations: Linked as related issues.
Scenarios
📄 Testing guide- Inspired by the scenarios used in CM Scorecard - Create:Source Code:Code Review FY21-Q2 (testing guide for JTBD 1 and 2 of that study).
- Since the goal is to identify opportunities to improve the perceived performance of MRs, we'll use the test MRs discussed in gitlab#327128 (closed)
Identified opportunities
Sidebar
- Reduce number of loading spinners in issuables sidebar: gitlab#333656
Commenting
- Improve commenting loading states: &6190
- Don't auto-load resolved thread replies in MRs: gitlab#333657 (closed)
- Give immediate feedback when emoji reacting to an issuable/comment: gitlab#333658 (closed)
- Make submitting 1 MR review comment as fast as 1 non-review comment: gitlab#333659 (closed)
- Remove temporarily duplicated comments when submitting an MR review: gitlab#333661 (closed)
- Improve button loading states of MR reviews feature: gitlab#333662 (closed)
- Add loading state to collapse/expand all threads button in MRs: gitlab#333664
Diff
- Add loading state when changing preferences in MR: gitlab#335414
- Scroll position changes when files are loading above in MR: gitlab#333666 (closed)
- Add loading state when toggling “Show full file/changes only” in MR file options: gitlab#331456
- Add loading state when showing unchanged lines in MR: gitlab#333668
- Reduce number of spinners when loading files in MR and add more predictable loading state to the MR “Changes” tab contents: &5364 (closed)
Edited by Pedro Moreira da Silva