[go: up one dir, main page]

Skip to content

Scroll position changes when files are loading above in MR

Summary

This might not be a large bug, but it can be very annoying. Particularly in large MRs, if there are still files loading above the current scroll position, the scroll position keeps changing until all files above have been loaded.

CleanShot_20210513124713

Steps to reproduce

  1. Navigate to the changes of a large MR (example)
  2. Click on a file in the middle of the file browser

Example Project

https://gitlab.com/pedroms/gitlabhq1/-/merge_requests/8785/diffs

What is the current bug behavior?

The scroll position keeps changing until all files above have loaded.

What is the expected correct behavior?

This one is challenging to solve. Ideally we would try to maintain the scroll position when I've clicked on a specific file in the file browser or have navigated via an anchor link.

Output of checks

This bug happens on GitLab.com