[go: up one dir, main page]

Menu

#1036 SVN team project files disappear

5.4.2
closed-fixed
9
2021-05-19
2021-02-12
No

Since in 5.4 file deletions are propagated ([feature-requests:#1499]), SVN team projects lose local files.

To see what files are deleted, before and after checkouts, the list of checked out files is compared. This works fine for Git, but for SVN not always. In case OmegaT checks out a single fie like omegat/project_save.tmx, in SVN not all files are checked out, but only all files in the same folder (e.g. omegat/). All source files are gone, and thus the deletion of them is propagated.

Solutions:
- disable the feature for SVN
- replace implementation with something that marks 'last full checkout', and checks the logs for file deletions since the last full checkout, on project load

Related

Bugs: #1232
Feature Requests: #1499

Discussion

  • Aaron Madlon-Kay

    It sounds like temporarily disabling the feature for SVN is the right choice if a comprehensive fix is at all difficult.

     
  • Marco Cevoli

    Marco Cevoli - 2021-02-22

    And why are file deletions propagated? Wouldn't it be safer and wiser to revert that change and not letting many Subversion users with no alternative than moving projects to another system?

     
    • Aaron Madlon-Kay

      Can you please see if the issue is resolved in this build?

      (Inside the outer ZIP is an inner ZIP; inside that is the build.)

       
    • Aaron Madlon-Kay

      Are you interested in helping confirm the fix?

       
      • Marco Cevoli

        Marco Cevoli - 2021-03-21

        I've tried the 5.5 nightly build and the bug seems to be fixed. I haven't
        tested it extensively though.

         

        Last edit: Aaron Madlon-Kay 2021-03-22
        • Aaron Madlon-Kay

          Could I get you to test the 5.4.2 build I linked to?
          https://sourceforge.net/p/omegat/bugs/1036/#77fa/61f8

           
          • Marco Cevoli

            Marco Cevoli - 2021-03-23

            Tested with 5.4.2 linked above. Target file created.

             
            • Aaron Madlon-Kay

              Thank you.

               
  • Aaron Madlon-Kay

    Since this feature is significantly more complicated than it initially seemed, and the timeline for v5.5 is not yet clear, I would like to put out v5.4.2 with it disabled for SVN.

    I have created a new branch release/5.4.2. Could you disable the feature for SVN directly on that branch?

     
  • Aaron Madlon-Kay

    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,4 +1,4 @@
    -Since in 5.4 file deletions are propagated, SVN team projects lose local files.
    +Since in 5.4 file deletions are propagated ([feature-requests:#1499]), SVN team projects lose local files.
    
     To see what files are deleted, before and after checkouts,  the list of checked out files is compared. This works fine for Git, but for SVN not always. In case OmegaT checks out a single fie like omegat/project_save.tmx, in SVN not all files are checked out, but only all files in the same folder (e.g. omegat/). All source files are gone, and thus the deletion of them is propagated.
    
     

    Related

    Feature Requests: #1499

  • Martin Fleurke

    Martin Fleurke - 2021-02-24

    5.4.2: disabled propagation for file deletions hwen using svn
    5.5.0: reimplemented (fixed) file deletion propagation for svn

     
    • Aaron Madlon-Kay

      Thank you!

       
  • Martin Fleurke

    Martin Fleurke - 2021-02-24
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -4,5 +4,4 @@
    
     Solutions:
     - disable the feature for SVN
    --  replace implementation with something that marks 'last full checkout', and checks the logs for file deletions since the last full checkout, and on different moments than every time OmegaT does some checkout
    --  ...
    +-  replace implementation with something that marks 'last full checkout', and checks the logs for file deletions since the last full checkout, on project load
    
    • status: open --> open-fixed
     
  • Aaron Madlon-Kay

    • summary: svn team project files disappear --> SVN team project files disappear
    • Group: 5.5 --> 5.4.2
     
  • Aaron Madlon-Kay

    The temporary fix is released in 5.4.2, but I will keep the ticket open until 5.5 is out with the real fix.

     
  • Aaron Madlon-Kay

    • status: open-fixed --> closed-fixed
     
  • Aaron Madlon-Kay

    Final fix released in OmegaT 5.5.0.

     

Log in to post a comment.