Re: [LogiLogi-list] UI Integration - Names of boxes

On Wed, Sep 17, 2008 at 2:54 PM, Wybo Wiersma <wy...@lo...> wrote:
> I just committed some more wireing up and integration. The
> new_logilogi.html is now integrated in the trunk :)
>
> (hope we can work on the trunk now...)

it seems that my best way to work will be on my server on the LL
trunk... I'll be working there.

>
> Some bits may not have been copied over, especially regarding the
> secondary tabs, as I did not know what to do with those...
>
> I also made a start with hooking up remarks, but while doing that, and
> really already when adding the commenting logis, I ran across the
> naming of the bordered boxes, especially the different colored ones
> (those that should be differently colored in line with the svg)...
>
> Now most start with class="logi_current logi", and that may not be
> neatest... Now I bet you already planned on changing that, but maybe
> we should give all the boxes the same name, like border_box, or
> something, and then determine the color via the css, based on the div
> they are in... (just like we do with the primary tabs)
>
Well, all works this way. The rounded corners are always the same lt,
rt, rb, lb, but change the image depending on the context they are
applied.

The logi_current is a special case where the log border is different,
the rest are just logis.

the other aspect to take in count is that the corners that simulate
transparency are different for each box. On the nav-bar are dark blue,
in the sidebar soft, in the logi-borders white...

> (except maybe for the current logi, or the selected contender)
>
> This would make the styling clean, and really separate from the
> html (and allow putting the code needed for the box in a single
> layout partial, just like app/views/application/round_box.html.erb
> for the rounded boxes)...
>
> So if you like it that way, you can do it...

Right now, there are different ways I create the rounded corners, so I
don't think we can do this globally.

>
> I also did an attempt of fixing the min_height keeper in the current
> logi, with an overflow: auto, but it required setting the width of the
> logi_body manually... dunno if there is a better solution, as this one
> also breaks the border of the current logi...
>

I corrected this on the commit of early yesterday. I added a grey div
so you can see it, then we color it white.

> In all fixes I did I sticked closely to the SVG, and I am using
> Firefox 3.0.1 on linux for it... Hope it is not too different from the
> other Firefoxes...
>

I'm starting to work on the trunk right now :) See you in a coupple of hours.

Greetings

-- 
Bruno