Menu
▾
▴
Re: [ jEdit-devel ] Fwd: recent changes to jEdit 5.2
|
From: Vampire <Va...@jE...> - 2014-08-13 17:02:52
|
Dale, why do you think this is a problem in BufferTabs? BufferTabs paints its background with the "highlighted" color, as the current tab is the selected one. I think this is ok. As far as I remember BufferTabs architecture, it cannot add the textarea as its child component properly which would maybe also solve this problem. But as far as I remember it cannot do it in another way than it does. I've had a look at it last night myself and fixed it the way I suggested before. Do you think this change (r23651) is wrong? The problem was like I described, that now - as you can set the four corners' components individually - they might be shown without a component in them. Before this only affected the bottom right corner between the scrollbars. In the bottom left, the horizontal scrollbar was shown and the upper corners were not shown, or filled with the top component on full length, like e. g. the ColumnRuler. And as the TextArea extends JComponent, it does not draw its background or anything at all, but only draws its children. I now changed it so that TextArea extends JPanel and set its background color to the Gutter background color. I also tried with the default JPanel background color, but thought with the Gutter background color it looks a ton better. Cheers Björn 2014-08-10 3:42 GMT+02:00 Alan Ezust <ala...@gm...>: > It looks like the only person committing to it these days (BufferTabs) is > me. I can see from the logs that kpouer used to maintain it properly, but I > doubt he's got time for it now. If you have fixes to make into it, be my > guest. > > > > > On Sat, Aug 9, 2014 at 6:33 PM, Dale Anson <da...@da...> wrote: > >> I spent some time looking into this and the problem is in BufferTabs. Is >> anyone maintaining BufferTabs at the moment? It is doing some things with >> the look and feel that I didn't get to the bottom of for no reason that I >> can tell. It also has some threading issues that cause painting problems >> and it won't start automatically for me, probably due to the threading >> issues. >> >> Dale >> >> >> >> On Sun, Aug 3, 2014 at 1:58 AM, Vampire <Va...@je...> wrote: >> >>> Exactly, this can even be reproduced with a fresh new settings >>> directory. >>> >>> With no other plugins you will see the gray background shine through the >>> bottom right corner between the two scroll bars and since 5.2 also through >>> the bottom left corner between the gutter and the horizontal scroll bar. >>> >>> As soon as you install and activate buffertabs, the gray turns blue. >>> >>> If you additionally install and activate the column ruler plugin, it >>> gets even more visible, because then the upper left and right corners are >>> affected also. >>> >>> I guess the textarea should not leave those rectangles empty and let the >>> background shine through, but either fill them with the Gutter color or >>> maybe better with the L'n'Fs background color for the textarea or something >>> similar. I guess one has to just play around and see what looks best and >>> makes most sense. >>> >>> Regards >>> Björn >>> Am 01.08.2014 07:32 schrieb "Dale Anson" <da...@da...>: >>> >>> I agree, the blueness shouldn't be visible. Just so I'm clear on this, >>>> you don't have the look and feel plugin, you're using the metal theme from >>>> the general jEdit settings? >>>> >>>> >>>> >>>> >>>> On Thu, Jul 31, 2014 at 6:23 PM, Vampire <Va...@je...> wrote: >>>> >>>>> >>>>> Actually, it was just the Bug #3876 for both of my splash screen >>>>> problems. >>>>> >>>>> Using the native splash was bad for situations where you never show >>>>> any GUI, e. g. if you just open an existing file in jEdit, or even worse, >>>>> if you autostart the jEdit server. Then you will have the splash screen >>>>> there until you really open jEdit, or at least show the right-click menu on >>>>> the tray icon. Because that is a GUI element and causes the native splash >>>>> to go away. >>>>> >>>>> The problem that no progress messages were shown, was simply that I >>>>> had a nosplash file and didn't remember it. Actually I didn't remember it >>>>> because a splash screen was shown, but just the native one until jEdit >>>>> opened. >>>>> >>>>> So both of those problems were solved by removing the native splash >>>>> screen. :-) >>>>> >>>>> >>>>> >>>>> Regarding the blue corners, the "problem" was there before already in >>>>> the lower right corner, but just wasn't as visible. >>>>> Now with 5.3.2, the lower left and, if e. g. column ruler is active, >>>>> also the upper left and upper right corners are affected, because the >>>>> surrounding elements are not drawn from full left to right like it was >>>>> before. >>>>> The corners are simply not drawn. That means that the background of >>>>> the underlying component shines through. >>>>> If BufferTabs is enabled, the background is the selected TabPanel and >>>>> thus the blue color in case of metal L&F. >>>>> As long as it was just the small little square in the bottom right >>>>> between the two scroll bars this didn't disturb much. >>>>> But as it affects now all four corners I think this is too prominent >>>>> and we should draw something there. >>>>> Maybe the gutter color, what do you think guys? >>>>> >>>>> Regards >>>>> Björn >>>>> >>>>> >>>>> >>>>> 2014-05-29 11:08 GMT+02:00 Eric Le Lay <ker...@us... >>>>> >: >>>>> >>>>> Le Tue, 27 May 2014 17:27:38 -0400, >>>>>> Alan Ezust <ala...@gm...> a écrit : >>>>>> >>>>>> > Vampire asks me in an IM: >>>>>> > >>>>>> (...) >>>>>> > > And second, are the changes to the Splash intended? If I now start >>>>>> > > jEdit, the Splash shows no progress or messages anymore but just >>>>>> > > sits there until jEdit is loaded completely. And if I know open >>>>>> > > another file in jEdit from outside, also the splashscreen is shown >>>>>> > > while it shouldn't as jEdit is already running and is just told >>>>>> > > what to do. >>>>>> > >>>>>> > >>>>>> > I can see progress and messages but the progress bar isn't as dark >>>>>> as >>>>>> > it used to be. >>>>>> > The splashscreen is shown in situations where it used to not be, >>>>>> that >>>>>> > is also true. But since it is not always "on top" it doesn't bother >>>>>> > me as much as it would have before Eric Le Lay's change. >>>>>> >>>>>> Hi, >>>>>> the darkness of the bar sure can be changed. >>>>>> Showing the splash-screen when loading the full jEdit and not showing >>>>>> it when you open a file from the outside while jEdit is already >>>>>> running can't be done easily when using the native splash-screen >>>>>> facility [1]. >>>>>> I guess one could write a first program checking for jEdit presence >>>>>> and >>>>>> telling it to load a file WITHOUT splash-screen and if it fails, >>>>>> running >>>>>> jEdit with splash-screen. >>>>>> This implies starting the JVM twice so I'd say it is a bit overkill! >>>>>> I'm open to other ideas... >>>>>> >>>>>> Regarding the fact that nothing shows on the splash-screen, >>>>>> this may be an issue of threading on your platform/PC. >>>>>> I'm running ArchLinux with java version "1.7.0_55" >>>>>> OpenJDK Runtime Environment (IcedTea 2.4.7) (ArchLinux build >>>>>> 7.u55_2.4.7-1-x86_64) OpenJDK 64-Bit Server VM (build 24.51-b03, mixed >>>>>> mode) on a multiprocessor system so concurrent calls are very likely >>>>>> to be called in parallel. Maybe in your system it's not the case. >>>>>> >>>>>> >>>>>> >>>>>> [1] >>>>>> http://stackoverflow.com/questions/3477539/how-to-let-user-have-an-option-to-disable-splash-screen >>>>>> >>>>> >>>>> >>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Want fast and easy access to all the code in your enterprise? Index and >>>>> search up to 200,000 lines of code with a free copy of Black Duck >>>>> Code Sight - the same software that powers the world's largest code >>>>> search on Ohloh, the Black Duck Open Hub! Try it now. >>>>> http://p.sf.net/sfu/bds >>>>> -- >>>>> ----------------------------------------------- >>>>> jEdit Developers' List >>>>> jEd...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/jedit-devel >>>>> >>>>> >>>> >>> >>> ------------------------------------------------------------------------------ >>> Want fast and easy access to all the code in your enterprise? Index and >>> search up to 200,000 lines of code with a free copy of Black Duck >>> Code Sight - the same software that powers the world's largest code >>> search on Ohloh, the Black Duck Open Hub! Try it now. >>> http://p.sf.net/sfu/bds >>> -- >>> ----------------------------------------------- >>> jEdit Developers' List >>> jEd...@li... >>> https://lists.sourceforge.net/lists/listinfo/jedit-devel >>> >>> >> >> >> ------------------------------------------------------------------------------ >> >> >> -- >> ----------------------------------------------- >> jEdit Developers' List >> jEd...@li... >> https://lists.sourceforge.net/lists/listinfo/jedit-devel >> >> > |