Menu
▾
▴
[ jEdit-devel ] [ jedit-Patches-3614699 ] HTML mode: Fix mode properties in <script> blocks.
|
From: SourceForge.net <no...@so...> - 2013-11-26 19:23:33
|
Patches item #3614699, was opened at 2013-07-13 12:00 Message generated for change (Comment added) made by kerik-sf You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3614699&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Marc Häfner (marchaefner) Assigned to: Dale Anson (daleanson) Summary: HTML mode: Fix mode properties in <script> blocks. Initial Comment: Fix #3614631 by delegating to script modes, instead of just importing their rules. The indentation rules for the script mode are only applied if (real) delegation is used. (Some relevant code can be found in JEditBuffer.getIndentRules) This patch also shortens and simplifies the file nicely, but for the price of reintroducing a corner-case bug: Closing </script> tags may be consumed by script comments, which is inconsistent with the XML plugin and most browsers. Given that it seems impossible to fix this (in a mode file) while using (real) delegation, I'd say that having correct script mode properties is preferable to not having this bug. (Thanks to Matthieu Casanova for pointing in the right direction.) ---------------------------------------------------------------------- >Comment By: Eric Le Lay (kerik-sf) Date: 2013-11-26 11:23 Message: Hi, looks good to me. What about marking the whole end of attribute invalid when invalid entity is detected ? replace <SEQ>...</SEQ> with <SEQ_REGEXP TYPE="INVALID">&[^"]*</SEQ_REGEXP> Otherwise it's rather easy to miss those red & in pink url. Also, the old html mode will show all the javascript code as comment when viewing the source of this page: http://www.cs.umd.edu/~bederson/papers/index.html which the new mode doesn't, which is good! ---------------------------------------------------------------------- Comment By: Marc Häfner (marchaefner) Date: 2013-11-12 09:35 Message: Any plain old <script> // comment </script> consumes the closing tag (because the comment is matched by an EOL_SPAN). Subsequent text is still highlighted with JavaScript mode, but a look at the SideKick or a test with a browser reveals that it's actually HTML. (Fixing this was one of the goals of #3595104, but it seems to have caused more trouble than good.) ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2013-11-11 15:07 Message: Marc, could you post an example of "Closing </script> tags may be consumed by script comments, which is inconsistent with the XML plugin and most browsers." ? This patch is looking good to me, and as far as I can tell, even putting a javascript comment in front of the closing script tag looks good. ---------------------------------------------------------------------- Comment By: Marc Häfner (marchaefner) Date: 2013-11-08 05:05 Message: Added new version, that also includes a fix for #3615189. (Also renames STRING ruleset to ATTRIBUTE and removes an outdated comment.) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3614699&group_id=588 |