[ jEdit-devel ] [ jedit-Patches-2617610 ] fix [1953252] MSI installer should kill jEdit server firs

Patches item #2617610, was opened at 2009-02-19 22:13
Message generated for change (Comment added) made by kerik-sf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2617610&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Eric Le Lay (kerik-sf)
Assigned to: Alan Ezust (ezust)
Summary: fix [1953252] MSI installer should kill jEdit server first

Initial Comment:
The solution I propose is to execute a java class to connect to any jEdit server and ask it to exit.
In the patch, this is done directly at installation startup. It seems more convenient to me, as the installer runs full screen after that and one might then not be able to see that jEdit is asking one to save some file before exiting.

Footnote : while I tested it both with running and absent jedit server process without any issue, this would need scrutiny.

This patch needs #2328002 (https://sourceforge.net/tracker/index.php?func=detail&aid=2328002&group_id=588&atid=300588).



bug report is here :
https://sourceforge.net/tracker/index.php?func=detail&aid=1953252&group_id=588&atid=100588

----------------------------------------------------------------------

>Comment By: Eric Le Lay (kerik-sf)
Date: 2010-11-30 18:53

Message:
Hi,
here is a new patch, with conflicts resolved on win32installer.iss
I tested it this morning and it builds and runs fine.

Shlomy's suggestion of killing only the instance of jEdit running from the
installation directory seems overkill to me : this feature is a nicety to
casual users. It's not a big deal to kill all running instances. 
On top of that, it won't find an instance of jEdit running from the
install directory, but with a non default settings directory.

----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2010-11-25 18:50

Message:
Eric, I am sorry that nobody has reviewed this patch. Part of me wants to
just say commit it directly, but I will see if I can review and test it
myself. I have very little experience building the windows installer (i
assume that is the same as the msi installer?) but I guess nobody else has
any who is still in the project. 




----------------------------------------------------------------------

Comment By: Shlomy Reinstein (shlomy)
Date: 2010-03-15 00:31

Message:
Hi, I am not at all familiar with the Windows installer. Also, the
installer should only kill the jEdit server that runs from the target
directory of the installation. If multiple jEdit instances are running,
from different installations, it should not kill the other instances.
That's a very small point maybe, but worth mentioning.

----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2009-08-18 17:23

Message:
reassigning to shlomy

----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2009-02-24 07:49

Message:
vampire, can you please handle this one?


----------------------------------------------------------------------

Comment By: Eric Le Lay (kerik-sf)
Date: 2009-02-19 22:14

Message:
the installer/ServerKiller class is required for the windows installer, so
build it before
creating the executable.
File Added: build_installer_for_windows.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2617610&group_id=588