[ jEdit-devel ] [ jedit-Patches-1999448 ] More efficient and general fix for black hole bug

Patches item #1999448, was opened at 2008-06-21 07:08
Message generated for change (Settings changed) made by ezust
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1999448&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Kazutoshi Satoda (k_satoda)
>Assigned to: Matthieu Casanova (kpouer)
Summary: More efficient and general fix for black hole bug

Initial Comment:
I found joining lines is very slow only when folding
mode is set to other than 'none'.

Reproduction recipe:
  (WARNING: This will cause vary long hang up.)
  - Open doc/CHANGES.txt in jEdit source tree.
  - Do [Expand All Folds] (C+e x).
    (without this, another bug happens.)
  - Do [Select All] (C+a).
  - Try [Join Lines] (C+j).

This patch will speed up this situation by minimizing
calls to buffer.getFoldLevel().

Also, this patch will expand the care about black hole
bug to support ...
  - multi line edit including folded line
  - more folding modes other than 'explicit'
  - modification at the middle of folded range.

I want approval from Matthieu who made the current
fixes for the bugs.

----------------------------------------------------------------------

Comment By: Matthieu Casanova (kpouer)
Date: 2008-06-25 01:08

Message:
Logged In: YES 
user_id=285591
Originator: NO

Hi, I just tested the patch but there is a problem :

if I use explicit fold, with this buffer

{{{ hello

something

}}}

all folds are folded. I remove one "l" from hello. I think it should not
expand folds since the fold level is not changed

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1999448&group_id=588