[ jEdit-devel ] [ jedit-Bugs-659205 ] incorrect check in TagParser.java

Bugs item #659205, was opened at 2002-12-27 18:56
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=659205&group_id=588

Category: plugins
Group: normal bug
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Xavier Le Vourch (brittanysoft)
Assigned to: Nobody/Anonymous (nobody)
Summary: incorrect check in TagParser.java

Initial Comment:
in the routine getTagAtOffset at line 45, the error
code from `indexOf' is not checked correctly because of
the increment to endTag on line 44:

		int endTag = text.indexOf('>', startTag + 1) + 1;
		if(endTag == -1 || endTag < pos)
			return null;

My fix below was to check for 0 instead of -1:

[BATZ /d/dev/jEdit/CVS/plugins/XML/xml/parser] 648: cvs
diff
cvs server: Diffing .
Index: TagParser.java
===================================================================
RCS file:
/cvsroot/jedit/plugins/XML/xml/parser/TagParser.java,v
retrieving revision 1.12
diff -r1.12 TagParser.java
45c45
<               if(endTag == -1 || endTag < pos)
---
>               if(endTag == 0 || endTag < pos)


I've had problems with the plugin in the past for
getting the matching tag but I don't know if it's
directly related to this particular problem.

Xavier


----------------------------------------------------------------------

>Comment By: Slava Pestov (spestov)
Date: 2002-12-30 20:36

Message:
Logged In: YES 
user_id=2280

fixed in XML 0.9.2.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=659205&group_id=588