|
From: Slava P. <sl...@je...> - 2001-09-29 05:26:37
|
Hi, I didn't finish writing that e-mail and forgot to attach the patch before I hit send. Oops. You should obtain a SourceForge user account, so that you can commit this plugin to the jEdit CVS. Then others will be able to help out and contribute code much more easily. This plugin also seems to have problems working with Java source files that use packages. For example, I have a 'tags' file in my /home/slava/jEdit/ directory; if I try to follow 'jEdit.setProperty()' inside /home/slava/jEdit/org/gjt/sp/jedit/BeanShell.java, it will open /home/slava/jEdit/org/gjt/sp/jedit/org/gjt/sp/jedit/jEdit.java. Note that it resolves the path relative to the current buffer's path, not the tag file's path. The 'Follow Tag' user interface is a bit confusing. It shouldn't show the entries for super classes if they don't contain the tag in question. Also, if two classes define two methods with the same name, there seems to be no way to choose which class to open. Maybe this is a problem with my tag program? I am using Exuberant Ctags 3.4. Finally, you should use standard jEdit message and input dialog boxes (GUIUtilities.message(), .error(), .input()) instead of custom ones, to ensure a more consistent user interface. I hope you find this feedback useful. Slava On Sat, Sep 29, 2001 at 03:06:37PM +1000, Slava Pestov wrote: > Hi, > > This looks like a very useful plugin. I notice that right now the list > of tags files must be set on a global basis. While a project manager > plugin allowing settings to be changed on a per-project basis will fix > this, in the mean time I think you should make it try to find a 'tags' > file, by searching first in the directory of the current file, then > in the parent directory, then in the parent's parent directory, and so > on. Only if a 'tags' file is not found using that method, should it use > the list of tag files. > > I tried compiling the plugin under JDK 1.1 and it mostly works, with > the exception of a few JDK 1.2 specific methods being used > (Vector.add(), as opposed to Vector.addElement()). I know JDK 1.1 is > rather old, but it is still my primary JDK, because my computer is so > slow. I have attached a patch which makes the plugin work under JDK > 1.1; you can apply it if you want. > > Slava |