guitarix Git

Added a few fix to bugs I introduced in a previous merge request in the C++ bindings.

Many thanks again Hubert.
Merged now.
It looks like you prepare the source to be ready to port to GTK-3, is that your goal?

Yes. But I have concerns notably with lv2.

I'll probably submit for Gtk2 patches, like expanding gxw_demo to have more widgets: it's very useful to test the Gtk3 port.

That is very welcome, as I'll port the LV2 plugins to X11 /cairo anyway. Currently I'm working on a X11 /cairo based toolkit, which will replace GTK in the LV2 plugs as soon it is ready. But it would never be able to replace GTK in guitarix main.
https://github.com/brummer10/Xputty
So when you port guitarix to GTK3, we could make a big step at once.

X11? I only have Wayland here (ok XWayland for compat, but you get the idea). Also I think it should be doable to have Gtk3 for the LV2 plugin. It would just require some isolation.

My main motivation is that Gtk2 doesn't support HiDPI which is that Guitarix UI is ridiculously small, even though it's not as bad as some other apps.

Yea, most LV2 plugs this day's comes with a X11 or openGL based interface. I guess a lot of time have to pass before you really could use wayland without X.

Since we are on the topic, woud you want Gtk3 along side Gtk2 for Guitarix? It is not the approach I have take yet, but I could change course, better do it now than later.

Nope, I think best would be to replace gtk2 with gtk3 completely. Even if we skip some style files for the move,

My current work is at https://sourceforge.net/u/hub/guitarix/ci/gtk3-port/tree/

It build and mostly run, looks ok-ish but a lot of theming needs fixing still, and some widgets still have bugs.

unfortunately it wont build here, after some warnings about

warning: ‘GdkPixbuf* gtk_widget_render_icon_pixbuf(GtkWidget*, const gchar*, GtkIconSize)’ is deprecated: Use 'gtk_icon_theme_load_icon' instead [-Wdeprecated-declarations]
 = gtk_widget_render_icon_pixbuf(widget, get_stock_id(widget), GtkIconSize(-1));

I get:

default/libgxwmm/gxwmm/paintbox.cc: In member function ‘void Gxw::PaintBox::call_paint_func(GdkEventExpose*)’:
default/libgxwmm/gxwmm/paintbox.cc:134:40: error: cannot convert ‘GdkEventExpose*’ {aka ‘_GdkEventExpose*’} to ‘cairo_t*’ {aka ‘_cairo*’}
   gx_paint_box_call_paint_func(gobj(), event);
                                        ^~~~~
In file included from default/libgxwmm/gxwmm/paintbox.cc:28:
../libgxw/gxw/GxPaintBox.h:55:67: note:   initializing argument 2 of ‘void gx_paint_box_call_paint_func(GxPaintBox*, cairo_t*)’
 void gx_paint_box_call_paint_func(GxPaintBox *paint_box, cairo_t *cr);

oops let me fix this.

oh you mean the gtk3 branch?

You need to pass --generate-cpp-wrapper to the waf configure as I haven't yet checked the gxwmm wrappers in.

Ah, okay.
Yes, beside some warnings it build and run now. WOW. Great work so far.
It's mostly the rc/css stuff witch is missing now.
What I'm notice is that gtk3 seems to handle the animations far better then gtk2.