[Vis5d-users] Bug fix for Vis5d

Axel,

Thanks for reporting this problem.  [see below message]

The problem was that in soundingGUI.c, update_snd_widgets was calling
LUI_ButtonSetState for gtx->temp_button, even though that button was NULL
(it wasn't created in make_lui_stuff because gtx->vertsys was 0).  I don't
pretend to understand exactly what that button is for or why it is NULL
(what the heck is vertsys?), but a quick fix is to have LUI_ButtonSetState
check whether its argument is NULL:

Index: lui5/newbutton.c
===================================================================
RCS file: /cvsroot/vis5d/vis5d/lui5/newbutton.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 newbutton.c
--- lui5/newbutton.c	2000/08/05 19:26:49	1.1.1.1
+++ lui5/newbutton.c	2000/08/29 17:20:51
@@ -279,7 +279,7 @@
  */
 void LUI_ButtonSetState( LUI_NEWBUTTON *b, int state )
 {
-   if (b->toggle) {
+   if (b && b->toggle) {
       b->state = state;
       draw_button( b );
    }


This seems to correct the crashing bug you report.

Cordially,
Steven G. Johnson

PS. Bug reports like this are best sent to the Vis5d mailing list (see the
cc above).

On Tue, 29 Aug 2000, Axel Reimann wrote:
> Hi Steven,
> 
> I don't really know whom to address this
> bug report to -- so I'll try your address
> first ;)
> 
> All versions of Vis5D I've worked with 
> so far exit with a segfault (Linux/Mesa)
> if you do the following:
> 
> - open Vis5d: vis5d hole.v5d
> - press DISPLAY
> - press DISPLAY 0 -> Options
> - change any settings or not, it doesn't matter
> - press DONE
> - press Return to Vis5D
> 
> Et voila, you got a segfault.
> Is this behavior known already?
> 
> Happy greetings from Berlin,
> Axel
>