Details

Reviewers

emilio

Group Reviewers

layout-reviewers

Commits

rMOZILLACENTRAL1133b5c97587: Bug 1874826 - Avoid reconstruction due to change to block formatting context.

Bugzilla Bug ID

1874826

Test Plan

https://treeherder.mozilla.org/jobs?repo=try&revision=d84f314f56c3c94497263022e57996aeb139384c

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central
Branch: default

Unit TestsUnsound
View All

	Time	Test
	0 ms	code-review::mercurial WARNING: The base revision of your patch is not available in the current repository. Your patch has been rebased on central (revision None): issues may be positioned on the wrong lines.

Event Timeline

fredw planned changes to this revision.Jan 18 2024, 10:11 AM

fredw created this revision.

Herald added a project: secure-revision. · View Herald TranscriptJan 18 2024, 10:11 AM

Harbormaster completed remote builds in B617081: Diff 810533.Jan 18 2024, 10:11 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Jan 18 2024, 10:12 AM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

fredw updated this revision to Diff 810650.Jan 18 2024, 4:24 PM

fredw retitled this revision from WIP: Bug 1874826 Avoid reconstruction due to change to block formatting context. r=#layout to WIP: Bug 1874826 - Avoid reconstruction due to change to block formatting context. r=#layout.

Harbormaster completed remote builds in B617191: Diff 810650.Jan 18 2024, 4:24 PM

fredw planned changes to this revision.Jan 18 2024, 4:24 PM

fredw requested review of this revision.Jan 18 2024, 4:59 PM

fredw updated this revision to Diff 810681.

fredw retitled this revision from WIP: Bug 1874826 - Avoid reconstruction due to change to block formatting context. r=#layout to Bug 1874826 - Avoid reconstruction due to change to block formatting context. r=#layout.

fredw added a reviewer: layout-reviewers.

Herald added subscribers: zrhoffman, emilio. · View Herald TranscriptJan 18 2024, 4:59 PM

Harbormaster completed remote builds in B617212: Diff 810681.Jan 18 2024, 4:59 PM

fredw added a parent revision: D198962: Bug 1874826 - Add more tests for paint/layout containment change and floats. r=#layout.Jan 18 2024, 5:02 PM

fredw mentioned this in D198962: Bug 1874826 - Add more tests for paint/layout containment change and floats. r=#layout.Jan 18 2024, 5:12 PM

emilio accepted this revision.Jan 18 2024, 5:40 PM

emilio added a project: testing-approved.

emilio added inline comments.

layout/generic/nsBlockFrame.cpp
6419	Actually we could avoid invalidating at all if we're already a static bfc right? So maybe `if (HasAnyStateBits(NS_BLOCK_STATIC_BFC)) { return; }` above? I guess that leaves the dynamic bfc bit potentially unset, but I don't think it can cause harm. If not, at least make this condition `if (MaybeHasFloats() && HasAnyStateBits(NS_BLOCK_STATIC_BFC)) {` or so? Anyways, looks good, and given we're dirtying I'd be happy to get this landed before the soft-freeze if you want, your call.
layout/generic/nsBlockFrame.h
681	Could be a static function in nsBlockFrame.cpp now if you want.