[go: up one dir, main page]

Dac: support http(s) and url in dac node binary

Context

This MR allows http(s) and url endpoints for the rpc addresses in dac node binary. Ip address format is still be supported. It relies on Dac_clic_helpers.Pared_rpc which was introduced in !9366 (merged).

Second part of !9366 (merged). Closes: #5969 (closed), #5970 (closed)

Manually testing the MR

make
./octez-dac-node configure as committee member \
    with coordinator https://dac-coordinator.gcp.marigold \
    and signer tz4XRGTG4yG8pmVJinyhKmujSRciNDxzKEzY
./octez-dac-node configure as observer \
   with coordinator 127.0.0.1:10832 \
   and committee member rpc addresses 127.0.0.1:10833 https://dac-member2.gcp.marigold.dev

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Ryan Tan

Merge request reports

Loading