[go: up one dir, main page]

p2p/test: prevent double close of pipes in test using fork processes

Context

The tests below are failing with bad file descriptor exception in the CI:

These tests fork some processes from Process.detach.

In this function, some pipes are closed from the usage of close-on-exec flag and from explicit calls of close function in the child processes.

This MR use the patch made by @romain.nl that removes the usage of close-on-exec flag.

Fix #5868 (closed)

Manually testing the MR

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Vivien Pelletier

Merge request reports

Loading