[go: up one dir, main page]

EVM on WASM: Make sure REVERT can return data

Context

The Ethereum REVERT opcode allows for returning data - just like the RETURN opcode (and unlike the STOP opcode). Previously we actually had a bug in the EvmHandler so that this didn't work. A few MRs ago I fixed this (the refactoring of transactions and errors). This was mostly a fix by accident. This MR introduces a test to make sure we don't "accidentally" break this again.

Manually testing the MR

Run cargo make test in src/kernel_evm as usual. The unit tests run as part of the normal pipeline.

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports

Loading