[go: up one dir, main page]

p2p: remove cli arguments from p2p tests

Context

This MR removes all command line arguments to all p2p tests.

This is now necessary as we are moving all the unit tests to alcotezt ( check the milestone : %Unit tezts / Alcotezt ).

We also started some work to move integration tests directly to tezt without passing thought alcotest cli ( !7564 (merged) ).

This MR refactor all the p2p tests, while a new MR will move the tests to alcotezt. Some refactoring are more involved depending on how the test was previously coded. I tried not to touch the test itself, but just how it is run. However, the gist of the changes is the same everywhere.

Manually testing the MR

All tests should run as before. the arguments that were passed to the tests in the via the dune file, are now the default arguments.

Note that to run the test in the CI the default localhost address is 127.0.0.1 (ipv4 localhost)

$ dune exec src/lib_p2p/test/test_p2p_socket.exe --  -v

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by pietro

Merge request reports

Loading