[go: up one dir, main page]

DAC: Refine and implement root hash streamer interface

Context

Update: As requested by the first review / realised by !7548 (merged) this MR also redefines the interface a bit.

Too see how Data_streamer component is meant to be used it is best to check it's integration/usage in !7548 (merged)

This MR does the following:

  1. Moves Data_streamer from bin_dac_node to lib_dac_node.
  2. Implements and tests Data_streamer.Root_hash_streamer interface.

The MR is part of #4655 (closed). With this MR we have implementation of the root hashes component that coordinator will eventually have integrated into the node context. In the subsequent MRs dac members will be able to subribe to the coordinator for the root hashes and coordinator will internally "delegate" the work to this component. Note that as such it will be coordinator that will handle all the subsription and publication work using this component (as an internal one). If it goes down all the pub sub information will be lost, furthermore we currently have no concept of offset.

closes: #4740 (closed)

Manually testing the MR

dune exec src/lib_dac_node/test/main.exe -- test "^\[Unit\] Data_streamer.ml$"

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Martin Tomazic

Merge request reports

Loading