[go: up one dir, main page]

Protocol/SCORU: Add some comments for the rejection

François Thirérequested to merge
francois@scoru-rejection-comments into master

Trying to understand how the rejection works, I stumbled across the produce_proof function which sounds a bit obscure to me. I have tried to add comments to help the next reader.

Questions to the reviewers:

  1. The call to Option.map (lift_ptr_path deref) seems weird since we do (List.last_opt inc) after. We could first take the last element. In practice, it should not have a big impact though because the list should be fairly small.
  2. I am not sure about the ordering of the list returned by Skip_list.back_path. In particular, why we take the last element of this list?
  3. Maybe my comment is wrong, but I don't understand the level associated to the variable upper_level. Is it the current head of the inbox? If so, why the payload can be empty? Otherwise, is upper_level = target_index?
Edited by François Thiré

Merge request reports