[go: up one dir, main page]

Proto,Test: put back rng state to fix flakiness

Context

As the description says:

(** Regression test to ensure that we can reject a commitment where the
    proof is truncated to be close to the maximum size limit (i.e. 32Kb) and
    the rejected message size is close to the maximum size (i.e. 5Kb).

    It also test that all required parameters for the rejection fits in a
    Tezos operation even in the worst cases.
*)

It is complicated to get numbers close to this, to ensure that the test is not flaky we fixed the rng_state so the proof size and message was the same in every run. However, it was reverted in 35e8ea1c, making the test flaky.

Manually testing the MR

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports

Loading