[go: up one dir, main page]

Manifest (12): leftovers

This is a small subset of !3366 (merged), which aims at generating dune and .opam files from a manifest.ml file. See !3366 (merged) for a broad view of the end goal.

Because !3366 (merged) is too large to review in one go, the plan is to make several MRs targetting subparts of the dune and .opam files, without the generator itself. The goal is to check all changes in dune and .opam files made by !3366 (merged). Even if we do not merge !3366 (merged) ever, we'll fix some inconsistencies between dune and .opam files this way. After all changes to dune and .opam files have been reviewed and merged, we can merge the generator itself and easily see that it generates the exact same files.

This MR contains leftovers from the previous set of MRs. It:

  • updates version numbers of some dependencies (we want the version constraints to be the same everywhere);
  • fixes a few inconsistencies between .opam and dune files;
  • handles two more dune files for tests.

General Review Tips

patdiff helps a lot, as well as the -w option of git diff. You can use patdiff with git diff as follows:

opam install patdiff
export GIT_EXTERNAL_DIFF=`pwd`/_opam/bin/patdiff-git-wrapper

If you read the diff in GitLab, the -w option of git diff can be activated by opening preferences (the gear icon while reviewing) and unchecking "show whitespace changes".

Apparently, VS Code is also very nice to review whitespace diffs.

Manually testing the MR

Compile everything (or let the CI do it for you).

Run tests of modified dune files that declare test with:

dune build @src/lib_crypto/runtest
dune build @src/lib_shell_services/test_helpers/test/runtest

Checklist

  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Romain

Merge request reports

Loading