[go: up one dir, main page]

Resto/CI: use a fresh port in [chunked_output] and fail faster in the CI

Bruno Brequested to merge
bruno-fix-resto-unit into master

What

  • Uses a fresh port instead of a hardcoded one in Resto's chunked output integration tests.
  • Sets the timeout to 10 min (from 60 min) for the resto.unit-<arch> jobs.

Why

To reduce flakiness of resto.unit:x86_64. E.g. 4 failures yesterday:

All raising a Unix.EADDRINUSE error (address already in use).

Timeout is lowered as

  • this job should be quick (< 1 min in my observations)
  • failing fast is better.

How

  • We use a fresh port instead of a hardcoded one. (We reuse a Tezt function.)
  • We also set the socket with the SO_REUSEADDR to be able to reuse a port that is in TIME_WAIT after the socket is closed.

NB: this is a quick fix to avoid pipeline failures. Not all flakiness is eliminated (cf. test results below) but this MR seems to improve the situation. A better but more time-consuming solution could be to port these tests to Tezt.

Manually testing the MR

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Bruno B

Merge request reports