[go: up one dir, main page]

Etherlink/Node: match chain_family accross GADTs

Stacked on !18349 (merged).

Closes L2-87

What and why

  • In !17777 (merged) we introduced 3 GADTs to statically track the chain family.
  • When introducing the Tezlink Tx-queue in !17697 (merged) and the Tezlink forward-request container in !18349 (merged), we did not change the fact that the tx-containers currently launched are the Etherlink ones, even if the configuration says that the chain family is "Michelson".
  • In this MR, we statically force the chain family to match across the configuration, the tx container, and the RPC server. This means in particular that with this MR, the Tx queue launched by the sequencer in the case of a Tezlink chain is the Tezlink tx queue.

How

  • In the first three commits, we make all tx container implementations but the tx queue and the forward-request container fail in the case of Tezlink,
  • In the fourth commit, we pass the actual chain family (instead of hardcoding "EVM") to the functions initializing tx containers and we also prevent launching a RPC server with a tx container for another chain family.
  • In the fifth (and last) commit, we make Tezlink test use the tx-queue instead of the now-failing tx-pool.

Manually testing the MR

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Raphaël Cauderlier

Merge request reports

Loading