[go: up one dir, main page]

EVM Node: RPC responses revert to lower-case addresses

Thomas Letanrequested to merge
lthms@etherlink--lowercase-addresses into master

What

This patch reverts to the behavior exhibited before commit db1459fd. Specifically, This change reverts the behavior of the EVM node's RPC endpoints to output Ethereum addresses in lowercase hexadecimal format, instead of the EIP-55 checksummed format.

Why

Returning EIP-55 checksummed addresses directly from RPC responses is not standard behavior for most EVM-compatible nodes. Major clients like Geth return lowercase addresses, leaving it to client-side applications to apply checksums for display. Adhering to this de facto standard improves compatibility with the wider Ethereum tooling ecosystem.

How

The Ethereum_types.Address.to_string function has been simplified back to output only lowercase hex strings. The previous EIP-55 checksumming logic was moved to a new, explicitly named function, to_eip55_string. This new function is used where checksums are still beneficial for direct user display, like in the show kms key info command. All RPC-related types and encodings were updated accordingly. The test suite has been reverted to assert against the new lowercase address format in RPC responses.

Manually testing the MR

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports