[go: up one dir, main page]

Tezt/Cloud/DAL: If the producer indices are not specified, we should start from 0 not 1

Guillaume Genestierrequested to merge
GuillaumeG@Produce_from_0_by_default into master

What

When launching a tezt-cloud experiment without specifying the indices on which the producer should publish data, then select starting from 0 not 1.

Why

Because today when launching the experiment with 32 producers, the last one does not produce (unless you pass the --producer-slot-indices 0 option) because of this off by one mistake.

How

Set the initial value of the reference to -1 so that after the incrementation, the first selected slot is 0.

Manually testing the MR

Launch your favorite command which does not mentions the producer slot index but where slots are published and see that the produced slots are now starting from 0.

(To ease testing, here is my favorite command respecting previous criteria:

make && dune exec tezt/tests/cloud/main.exe -- DAL -v --website --grafana --log-file /tmp/log_$(date "+%Hh%M") --producers 1 --localhost --tezt-cloud guillaumeg --dockerfile-alias dal --stake 2,2

)

Merge request reports