[go: up one dir, main page]

Tezt/Cloud/DAL: fix "we lack info" for bakers using consensus keys

Victor Allombertrequested to merge
vicall@dal_fix_lack_info into master

This MR aims to fix the DAL scenario recap when it comes to summarize the bakers ration. Indeed, bakers using consensus keys were showing we lack information (as the consensus key was not associated to the delegate field found in the attestations).

Manually testing the MR

Run a local scenario (rionnet is faster) from a recent rionet snapshot (use the v9 format as usual).

dune exec tezt/tests/cloud/main.exe -- DAL --producers 1 --producer-slot-indices 9 --log-file experiment_$(date "+%Hh%M").log --network sandbox --tezt-cloud rionet-1-producers --dockerfile-alias dal --keep-temp -v --localhost --snapshot file:./recent_rionet_snapshot.rolling.v9 --simulate scatter(40,2)

Look for the recap after baking a few blocks

[08:03:10.082] [TOP] Level 3159422's info processed
[08:03:10.082] First commitment published level: 3159383
[08:03:10.082] First commitment attested level: 3159391
[08:03:10.082] Total published commitments: 40
[08:03:10.082] Expected published commitments: 40
[08:03:10.082] Total attested commitments: 32
[08:03:10.082] Ratio published commitments: 100.000000
[08:03:10.082] Ratio attested commitments: 100.000000
[08:03:10.082] Ratio published commitments last level: 100.000000
[08:03:10.082] baker-0: Ratio for baker_1 (with stake 0): 100.00
[08:03:10.082] baker-0: Ratio for baker_3 (with stake 0): 100.00
[08:03:10.082] baker-0: Ratio for baker_5 (with stake 0): 100.00
[08:03:10.082] baker-0: Ratio for baker_7 (with stake 0): 100.00
[08:03:10.082] baker-0: Ratio for baker_9 (with stake 0): 100.00
[08:03:10.082] baker-1: Ratio for baker_0 (with stake 0): 100.00
[08:03:10.082] baker-1: Ratio for baker_2 (with stake 0): 100.00
[08:03:10.082] baker-1: Ratio for baker_4 (with stake 0): 100.00
[08:03:10.082] baker-1: Ratio for baker_6 (with stake 0): 100.00
[08:03:10.082] baker-1: Ratio for baker_8 (with stake 0): 100.00
[08:03:10.082] baker-1: Ratio for baker_10 (with stake 0): 100.00
[08:03:10.082] Sum of balances of the Etherlink operator: 0 tez
[08:03:10.082] DAL slots: total published commitments per slot (<slot index> -> <published commit.>).
[08:03:10.082] [ (9 -> 32) ]
[08:03:10.082] DAL slots: total attested commitments per slot (<slot index> -> <attested commit.>).
[08:03:10.082] [ (9 -> 32) ]

We can see that baker_3 and baker_5 are showing stats even if they are using consensus keys: https://rionet.tzkt.io/tz1NNT9EERmcKekRq2vdv6e8TL3WQpY8AXSF and https://rionet.tzkt.io/tz1TGKSrZrBpND3PELJ43nVdyadoeiM1WMzb. Without this MR, these bakers are showing the we lack info :

[08:10:10.078] [TOP] Level 3159391's info processed
[08:10:10.078] First commitment published level: 3159382
[08:10:10.078] First commitment attested level: 3159390
[08:10:10.078] Total published commitments: 10
[08:10:10.078] Expected published commitments: 10
[08:10:10.078] Total attested commitments: 2
[08:10:10.078] Ratio published commitments: 100.000000
[08:10:10.078] Ratio attested commitments: 100.000000
[08:10:10.078] Ratio published commitments last level: 100.000000
[08:10:10.078] baker-0: Ratio for baker_1 (with stake 0): 100.00
[08:10:10.078] We lack information about tz1PCSaDNqHJxQxvyQVAARTqLXzfAfhhDUfG
[08:10:10.078] We lack information about tz3cveMb6Pt65pPcjeR8KWfyad2YSqd1wjE3
[08:10:10.078] baker-0: Ratio for baker_7 (with stake 0): 100.00
[08:10:10.078] baker-0: Ratio for baker_9 (with stake 0): 100.00
[08:10:10.078] baker-1: Ratio for baker_0 (with stake 0): 100.00
[08:10:10.078] baker-1: Ratio for baker_2 (with stake 0): 100.00
[08:10:10.078] baker-1: Ratio for baker_4 (with stake 0): 100.00
[08:10:10.078] baker-1: Ratio for baker_6 (with stake 0): 100.00
[08:10:10.078] baker-1: Ratio for baker_8 (with stake 0): 100.00
[08:10:10.078] baker-1: Ratio for baker_10 (with stake 0): 100.00
[08:10:10.078] Sum of balances of the Etherlink operator: 0 tez
[08:10:10.078] DAL slots: total published commitments per slot (<slot index> -> <published commit.>).
[08:10:10.078] [ (9 -> 2) ]
[08:10:10.078] DAL slots: total attested commitments per slot (<slot index> -> <attested commit.>).
[08:10:10.078] [ (9 -> 2) ]

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports