[go: up one dir, main page]

Draft: DAL/Node: trace gossipsub messages publication

What

Trace message publication within gossipsub worker.

Why

This adds more data to the traces, in order to witness if there are some blockers from the publishment point of view.

How

  • Improve Gossipsub worker to retain the Opentelemetry scope that served to produce the message.
  • When publishing shards, propagate this scope that contains the trace id.
  • Inside the worker loop, reuse the given scope to associate the span to the right scope, ensuring it will belong to the right trace id.

This change to propagate the scope has also been done for our generic worker, if you want to have another example or more context: !16148 (merged)

Manually testing the MR

Run the same scenario as in !18417 (merged). You can now witness the following:

image.png

which are all the shards published by the node.

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports

Loading