[go: up one dir, main page]

Baker: move check_node_version in agnostic library

What & Why

Instead of copy pasting the logic, moves the [node_check_version] in the agnostic baker. This is a preliminary refactoring to move all the CLI logic in the agnostic baker to avoid inconsistency between protocol-bakers.

The merge request contains only one commit as these refactoring are painful to review. I'm splitting in as many merge requests as possible so you don't have to spend hours reviewing stupid changes.

Manually testing the MR

I would hope it's something covered by the tests but you can always test the difference between the different versions based on what is refactored.

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports

Loading