[go: up one dir, main page]

Tezt: tag some tests with memory_3k

Romainrequested to merge
romain-tezt-memory-tag into master

What

This MR tags some Tezt tests with tag memory_3k.

Why

So that those tests run in a job where Tezt isn't run with -j, i.e. so that the tests do not run in parallel with other tests in the same job.

We recently measured how much memory each test is using. The results are probably wrong, because some tests that are known to use more than 2GB of memory were identified to only use 470MB. Still, the results showed that specific tests were outliers:

  • p2p-maintenance-init-expected_connections: 4.8GB
  • p2p-swap-disable: 3.4GB
  • p2p-peer-discovery: 1.7GB
  • p2p-peer-discovery-disable: 1.7GB
  • p2p-maintenance-disabled: 1.7GB
  • demo_counter: 1.1GB
  • demo_noops: 1.1GB

(all other tests were measured at less than 500MB).

I was able to measure p2p-maintenance-init-expected_connections at more than 4GB myself, demo_counter at 915MB and demo_noops at 919MB. Which is probably not enough to explain our OOMs, but since those are the outliers of our (flawed) measurements, let's start with that. In the future we'll want to revisit those tags with more accurate measurements.

How

Add tag Tag.memory_3k with a comment giving the measured memory usage.

Manually testing the MR

If you want you can try to run memstat to reproduce my manual measurement. Here is how to do it for demo_noops:

git checkout romain-memstat
make
dune build tezt/tests/main.exe memstat/main.exe
_build/default/memstat/main.exe run -rv _build/default/tezt/tests/main.exe \\-t 'demo_noops'

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports