[go: up one dir, main page]

RISC-V: Prefer `new` over `allocate` with `bind`

Part of RV-568

Stacked MRs

What

Switch all remaining uses of allocate+bind to use the new mechanism from !17567 (merged).

Why

Please refer to !17567 (merged) for more context!

How

Replaces the crate_state! macro for state instantiation in tests. I wanted to implement this switch within the crate_state! macro initially. This turned out to be quite messy, so I chose to simply replace the macro altogether.

Manually Testing

make -C src/riscv all

Benchmarking

This does not impact runtime performance.

Tasks for the Author

  • Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
  • Eliminate dead code and other spurious artefacts introduced in your changes.
  • Document new public functions, methods and types.
  • Make sure the documentation for updated functions, methods, and types is correct.
  • Add tests for bugs that have been fixed.
  • Put in reasonable effort to ensure that CI will pass.
    • make -C src/riscv
    • dune build src/lib_riscv
    • dune build src/rust_deps
  • Benchmark performance and populate the table above if needed.
  • Explain changes to regression test captures when applicable.
  • Write commit messages to reflect the changes they're about.
  • Self-review your changes to ensure they are high-quality.
  • Complete all of the above before assigning this MR to reviewers.
Edited by Ole Krüger

Merge request reports

Loading