Evm/node: split tx queue callback
Checklist
- [ ] Provide automatic testing.
- [ ] Add an item in the changelog
Internal modification for code quality.
What, why and how
meta-issue for the over project: #7785
Split the tx_queue callback type into two variant. This allows for a more fine grained definition of callback inside the tx_queue. It's hidden in the implementation of the tx_queue and so the signature of the module is untouched.
Why ? because I've spend a stupid amount of time looking to understand why my callback was not call, and it was simply because it was never called. The problem was instrumented_callback adds the given callback to the pending_transaction and not the instrumented one, this is stupid but with more precise callback definition I would have seen that faster. Also when debugging I wrote most of the code, and so I thought it was a good code improvement.
see !16829 (merged) for a first usage