[go: up one dir, main page]

Agnostic_baker: Fix and improve tezt testing

Gabriel Moiserequested to merge
gabriel@agnostic_baker_tezt_fix into master

What

When the agnostic-baker test was moved from manual_tests to tezt (see related commit), the registration was done incorrectly.

The migration test should have happened for each possible migration. Now, with this, there will be a migration scenario for Quebec (to Next) and for Next (to Alpha).

Furthermore, there was a bug with the protocols considered (protocol beta was considered, whereas next should have been).

Why

To be able to test all scenarios that can be applied to the migration process of the agnostic baker.

How

By registering the migration tests for the protocol before Alpha (in this case Next) and for the older protocols that are available (in this case Quebec)

Manually testing the MR

One can test the changes with the tezt test:

dune exec tezt/tests/main.exe -- --file agnostic_baker_test.ml
[23:09:38.512] [SUCCESS] (1/9) Agnostic baker starts and stops
[23:10:11.096] [SUCCESS] (2/9) Protocol migration from protocol next to protocol alpha with agnostic baker
[23:10:46.100] [SUCCESS] (3/9) Protocol migration from protocol next to protocol alpha with agnostic baker using HTTP remote signer
[23:11:18.100] [SUCCESS] (4/9) Protocol migration from protocol next to protocol alpha with agnostic baker and resilience test
[23:11:53.113] [SUCCESS] (5/9) Protocol migration from protocol next to protocol alpha with agnostic baker using HTTP remote signer and resilience test
[23:12:25.083] [SUCCESS] (6/9) Protocol migration from protocol quebec to protocol next with agnostic baker
[23:13:00.083] [SUCCESS] (7/9) Protocol migration from protocol quebec to protocol next with agnostic baker using HTTP remote signer
[23:13:32.072] [SUCCESS] (8/9) Protocol migration from protocol quebec to protocol next with agnostic baker and resilience test
[23:14:07.103] [SUCCESS] (9/9) Protocol migration from protocol quebec to protocol next with agnostic baker using HTTP remote signer and resilience test

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Gabriel Moise

Merge request reports