[go: up one dir, main page]

Tezt: Fix agnostic baker migration test by adding --without-dal default

What

Since the introduction of the mandatory rule to either use --without-dal or --dal-node for a baker binary in alpha, the manual test migration for the agnostic baker fails, because in Q this option was not mandatory.

Why

Any improvement on the agnostic-baker binary should continue from a stable (working) state.

How

We add the default behaviour which is --without-dal to all the agnostic-baker calls.

However, after future work is merged, this hardcoded solution will be transformed into an automatic resolution. (see for instance the work on --auto-patch-cli)

Manually testing the MR

Do not forget to

rm -rf octez-agnostic-baker && dune build src/bin_agnostic_baker/main_agnostic_baker.exe && mv _build/default/src/bin_agnostic_baker/main_agnostic_baker.exe octez-agnostic-baker

Then, check if the test passes (before this MR, this test should not have passed) :

dune exec tezt/manual_tests/main.exe -- --file agnostic_baking.ml

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Mattias

Merge request reports

Loading