[go: up one dir, main page]

Manifest: make it OCaml5 compatible

Pierrick Coudercrequested to merge
picdc@manifest-ocaml5-compatible into master

What

This is a oneliner change: add -I +str to the compilation command as its build path will not be added automatically in the future. This simply silences the warning. Note that its counterpart has already been added to manifest/dune.

Why

See https://github.com/ocaml/ocaml/pull/11198, or simply the message that is printed when compiling the manifest in an OCaml5 switch.

Manually testing the MR

With your OCaml5 switch, checkout on f3aa49efd0 and run make -C manifest. There will be a warning printed twice:

File "_none_", line 1:
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The str subdirectory has been
automatically added to the search path, but you should add -I +str to the
command-line to silence this alert (e.g. by adding str to the list of
libraries in your dune file, or adding use_str to your _tags file for
ocamlbuild, or using -package str for ocamlfind).

cherry-pick the commit from this MR and run it again: no warning anymore!

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports