[go: up one dir, main page]

Etherlink/Contracts: remove special case of 1-chunk delayed tx

Raphaël Cauderlierrequested to merge
rafoo@etherlink_chunked_delayed_transaction_no_special_case into master

What

Removes the special treatment of 1-chunk delayed transaction. With this commit, small delayed transactions are sent to the kernel using two inbox messages: the first message is 0x0001 which means that the number of chunks is one, the second message contains the transaction prefixed with 0x01.

Note: alternatively, we could keep a single message and use another tag (say 0x02) to indicate that this is a 1-chunk transaction. But this would require a kernel change to handle this new tag.

Why

There was no tag prefixed to non chunked transactions in the delayed inbox and this could lead to interference if the transaction's first byte is 0x00 or 0x01.

How

  • I removed the special case in the mligo script.
  • Then I recompiled the contract and committed the result.

Manually testing the MR

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports