Dal/Node: disable metrics by default
What
Do not enable the dal internal metrics service by default
Why
Metrics is suspected to leak memory
How
metrics-addr is now an option, that, when None, disables the metrics server
How to test
./octez-dal-node run --data-dir ~/.tezos-dal-node --rpc-addr 127.0.0.1:13732 --operator 0 --metrics-addr 0.0.0.0:36978
should show the line
Oct 01 15:44:04.353: metrics server is listening on ::ffff:0.0.0.0:36978
./octez-dal-node run --data-dir ~/.tezos-dal-node --rpc-addr 127.0.0.1:13732 --operator 0
should show the line
Oct 01 15:35:45.221: metrics service disabled by config, not starting
Edited by Guillaume B