[go: up one dir, main page]

Profiler: cleaner reset_profilers function

What

Replace a list of "hardcoded" calls to Profiler module functions by the standard method and use ppx in order to avoid code if not needed.

Why

No code generated if profiling is not enable at compilation time.

Better maintainability.

Breaking change

The old code don't check if the block used to reset the profilers is a new one or not and stop/restart the profilers no matter what. The new one only restart profilers if the block passed for resetting is different from the one currently opened. I can't see why it would be a problem to have this new check.

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports

Loading