[go: up one dir, main page]

Protocols: backport !15271 and !15295 to old protocols for OCaml5

What

Follow-up from !15271 (merged) and !15295 (merged), most of the old protocols won't typecheck starting OCaml5. As such they need to be patched.

Why

How

Patch them as in !15271 (merged) and !15295 (merged), and add the new protocol hashes to the alternative hashes map introduced by !15461 (merged)

Manually testing the MR

To check why these patches are necessary:

  • try to compile all these protocols with an OCaml5 switch (dune build @check). Don't try with the protocol compiler though, as it would fail for other reasons, see !15404 (281f58c0).
  • with OCaml4, you can remove the last commit that contains the protocol hashes table and run dune exec @runtest_compile_protocol as it directly calls the protocol compiler.

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Pierrick Couderc

Merge request reports

Loading