[go: up one dir, main page]

Revert "rust deps: bump crypto/encoding"

What

This MR reverts commits upgrading Kernel SDK, Etherlink, and other kernels to use Tezedge v0.6.0.

Why

The recent upgrade causes float point instruction errors in WASM PVM and the fastest way to bring master back to operational state is to revert related changes.

How

Revert all commits from !13965 (merged)

Manually testing the MR

Install necessary deps

cd etherlink/kernel_evm/benchmarks
npm i

In the repo root

make
make -f etherlink.mk EVM_KERNEL_FEATURES=debug evm_benchmark_kernel.wasm
node etherlink/kernel_evm/benchmarks/scripts/run_benchmarks.js -o /tmp/

If benchmark scripts are running without errors, everything is OK.

Alternatively (in the project root)

make -f etherlink.mk EVM_KERNEL_FEATURES=debug evm_benchmark_kernel.wasm
wasm2wat evm_benchmark_kernel.wasm -o kernel.wat
grep -nE 'f(32|64)\.' kernel.wat 

If there are no f32/f64 instructions then everything is fine (there might be f64 in the function names e.g. soft_f64 but that's ok).

There is also a new CI check: !14144 (merged)

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Michael Zaikin

Merge request reports

Loading