Crypto: Enable Yes-Crypto at runtime using an environment variable
What
Enable yes-crypto using an environment vairable
Why
Currently we need to apply a patch and recompile to launch octez binaries using yes-cryptography. This is inefficient, in particular in scenarios involving yes nodes and non-yes nodes. Besides, having it applied by default will help develop automatic tests using yes crypto.
How
By using a TEZOS_USE_YES_CRYPTO_I_KNOW_WHAT_I_AM_DOING environment variable.
To further protect against a misuage of this environment variable, nodes must also explicitely allow yes crypto by using the new argument --allow-yes-crypto.
Manually testing the MR
dune exec tezt/tests/main.exe -- --file yes_crypto.ml
Checklist
-
Document the interface of any function added or modified (see the coding guidelines) -
Document any change to the user interface, including configuration parameters (see node configuration) -
Provide automatic testing (see the testing guide). -
For new features and bug fixes, add an item in the appropriate changelog ( docs/protocols/alpha.rstfor the protocol and the environment,CHANGES.rstat the root of the repository for everything else). -
Select suitable reviewers using the Reviewersfield below. -
Select as Assigneethe next person who should take action on that MR
Edited by Mathias Bourgoin