Use unsigned int 32 to decode cemented offsets
The offsets of the cemented files are encoded as signed int32 but decoded with signed int31. It allows referencing data of a file of 1Gib max. This could be an issue when writing cycles containing many big blocks.
To avoid that, we propose to use unsigned int 32, allowing the handling of files up to 4Gib.
As a future work, we may want to use int64 to avoid such limitation.
Manually testing the MR
Should be transparent. Green CI.
Checklist
-
Document the interface of any function added or modified (see the coding guidelines) -
Document any change to the user interface, including configuration parameters (see node configuration) -
Provide automatic testing (see the testing guide). -
For new features and bug fixes, add an item in the appropriate changelog ( docs/protocols/alpha.rstfor the protocol and the environment,CHANGES.rstat the root of the repository for everything else). -
Select suitable reviewers using the Reviewersfield below. -
Select as Assigneethe next person who should take action on that MR
Edited by vbot