Proto/validate: check delegate is not forbidden in mempool mode too
What
Check that the delegate is not forbidden when validating a consensus operation in mempool mode too.
Why
- This avoids the mempool validating operations that can't be included in a valid block, which is bad for the baker. (Note: this could only happen when the forbidden delegate map was not empty, ie. when a delegate has committed at least two double signings, which usually doesn't happen.)
- Preventing forbidden delegates' operations from being propagated through the network helps protect them from incurring further slashings related to operations that can't threaten the chain anyway because they can't be included in blocks, leaving them some time to react of the double signing was caused by a faulty configuration.
How
Manually testing the MR
Checklist
-
Document the interface of any function added or modified (see the coding guidelines) -
Document any change to the user interface, including configuration parameters (see node configuration) -
Provide automatic testing (see the testing guide). -
For new features and bug fixes, add an item in the appropriate changelog ( docs/protocols/alpha.rstfor the protocol and the environment,CHANGES.rstat the root of the repository for everything else). -
Select suitable reviewers using the Reviewersfield below. -
Select as Assigneethe next person who should take action on that MR